From: Petr Baudis <pasky@ucw.cz>
Date: Wed, 11 May 2005 21:01:20 +0000 (+0200)
Subject: rev-tree now handles commit problems better
X-Git-Tag: v0.99~592
X-Git-Url: https://git.verplant.org/?a=commitdiff_plain;h=06cd3b94b27c285fc9877e7c6d9e1f35fbc0a7a4;p=git.git

rev-tree now handles commit problems better

This fixes possible crashes in case of broken commit tree, and makes
rev-tree die in case it cannot parse a given commit.
---

diff --git a/rev-tree.c b/rev-tree.c
index bfc8b125..c2909da1 100644
--- a/rev-tree.c
+++ b/rev-tree.c
@@ -51,11 +51,11 @@ void process_commit(unsigned char *sha1)
 	struct commit_list *parents;
 	struct commit *obj = lookup_commit(sha1);
 
-	if (obj->object.parsed)
+	if (obj && obj->object.parsed)
 		return;
+	if (!obj || parse_commit(obj))
+		die("unable to parse commit (%s)", sha1_to_hex(sha1));
 
-	parse_commit(obj);
-	
 	parents = obj->parents;
 	while (parents) {
 		process_commit(parents->item->object.sha1);