lpar plugin: update commen t regarding poll_idle vs pool_busy
authorAurelien Reynaud <collectd@wattapower.net>
Thu, 14 Oct 2010 20:09:28 +0000 (22:09 +0200)
committerFlorian Forster <octo@huhu.verplant.org>
Sat, 6 Nov 2010 08:39:33 +0000 (09:39 +0100)
Signed-off-by: Aurelien Reynaud <collectd@wattapower.net>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
src/lpar.c

index b9471fb..d25715e 100644 (file)
@@ -241,9 +241,8 @@ static int lpar_read (void)
                double pool_busy_cpus;
 
                /* We're calculating "busy" from "idle" and the total number of
-                * CPUs, because according to AurĂ©lien Reynaud using the "busy"
-                * member yields values that differ from the values produced by
-                * the LPAR command line tools. --octo */
+                * CPUs, because the "busy" member didn't exist in early versions
+                * of libperfstat. It was added somewhere between AIX 5.3 ML5 and ML9. */
                pool_idle_ns = lparstats.pool_idle_time - lparstats_old.pool_idle_time;
                pool_idle_cpus = NS_TO_TICKS ((double) pool_idle_ns) / (double) ticks;
                pool_busy_cpus = ((double) lparstats.phys_cpus_pool) - pool_idle_cpus;