intel_rdt plugin: const correctness
authorRuben Kerkhof <ruben@rubenkerkhof.com>
Sun, 3 Jun 2018 22:21:52 +0000 (00:21 +0200)
committerRuben Kerkhof <ruben@rubenkerkhof.com>
Sun, 3 Jun 2018 22:21:52 +0000 (00:21 +0200)
  CC       src/intel_rdt_la-intel_rdt.lo
src/intel_rdt.c: In function ‘rdt_read’:
src/intel_rdt.c:407:39: warning: passing argument 2 of ‘rdt_submit_derive’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
       rdt_submit_derive(cgroup->desc, "memory_bandwidth", "local",
                                       ^~~~~~~~~~~~~~~~~~
src/intel_rdt.c:339:51: note: expected ‘char *’ but argument is of type ‘const char *’
 static void rdt_submit_derive(char *cgroup, char *type, char *type_instance,
                                             ~~~~~~^~~~
src/intel_rdt.c:407:59: warning: passing argument 3 of ‘rdt_submit_derive’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
       rdt_submit_derive(cgroup->desc, "memory_bandwidth", "local",
                                                           ^~~~~~~
src/intel_rdt.c:339:63: note: expected ‘char *’ but argument is of type ‘const char *’
 static void rdt_submit_derive(char *cgroup, char *type, char *type_instance,
                                                         ~~~~~~^~~~~~~~~~~~~
src/intel_rdt.c:409:39: warning: passing argument 2 of ‘rdt_submit_derive’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
       rdt_submit_derive(cgroup->desc, "memory_bandwidth", "remote",
                                       ^~~~~~~~~~~~~~~~~~
src/intel_rdt.c:339:51: note: expected ‘char *’ but argument is of type ‘const char *’
 static void rdt_submit_derive(char *cgroup, char *type, char *type_instance,
                                             ~~~~~~^~~~
src/intel_rdt.c:409:59: warning: passing argument 3 of ‘rdt_submit_derive’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
       rdt_submit_derive(cgroup->desc, "memory_bandwidth", "remote",
                                                           ^~~~~~~~
src/intel_rdt.c:339:63: note: expected ‘char *’ but argument is of type ‘const char *’
 static void rdt_submit_derive(char *cgroup, char *type, char *type_instance,
                                                         ~~~~~~^~~~~~~~~~~~~

src/intel_rdt.c

index 667033c..62ce9b8 100644 (file)
@@ -25,9 +25,9 @@
  *   Serhiy Pshyk <serhiyx.pshyk@intel.com>
  **/
 
+#include "collectd.h"
 #include "common.h"
 #include "utils_config_cores.h"
-#include "collectd.h"
 
 #include <pqos.h>
 
@@ -336,8 +336,8 @@ static int rdt_config(oconfig_item_t *ci) {
   return 0;
 }
 
-static void rdt_submit_derive(char *cgroup, char *type, char *type_instance,
-                              derive_t value) {
+static void rdt_submit_derive(const char *cgroup, const char *type,
+                              const char *type_instance, derive_t value) {
   value_list_t vl = VALUE_LIST_INIT;
 
   vl.values = &(value_t){.derive = value};
@@ -352,8 +352,8 @@ static void rdt_submit_derive(char *cgroup, char *type, char *type_instance,
   plugin_dispatch_values(&vl);
 }
 
-static void rdt_submit_gauge(char *cgroup, char *type, char *type_instance,
-                             gauge_t value) {
+static void rdt_submit_gauge(const char *cgroup, const char *type,
+                             const char *type_instance, gauge_t value) {
   value_list_t vl = VALUE_LIST_INIT;
 
   vl.values = &(value_t){.gauge = value};