perl plugin: Fixed handling of erroneous configuration options.

An empty block was used instead of returning from the perl_config_*()
functions in case of an error. I wonder how that has happened... :-/

Signed-off-by: Sebastian Harl <sh@tokkee.org>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>

diff --git a/src/perl.c b/src/perl.c
index c0beabf..47844eb 100644 (file)
--- a/src/perl.c
+++ b/src/perl.c
@@ -907,8 +907,8 @@ static int perl_config_loadplugin (oconfig_item_t *ci)
        char *value = NULL;
 
        if ((0 != ci->children_num) || (1 != ci->values_num)
-                       || (OCONFIG_TYPE_STRING != ci->values[0].type)) {
-       }
+                       || (OCONFIG_TYPE_STRING != ci->values[0].type))
+               return 1;
 
        value = ci->values[0].value.string;
 
@@ -934,8 +934,8 @@ static int perl_config_basename (oconfig_item_t *ci)
        char *value = NULL;
 
        if ((0 != ci->children_num) || (1 != ci->values_num)
-                       || (OCONFIG_TYPE_STRING != ci->values[0].type)) {
-       }
+                       || (OCONFIG_TYPE_STRING != ci->values[0].type))
+               return 1;
 
        value = ci->values[0].value.string;
 
@@ -953,8 +953,8 @@ static int perl_config_enabledebugger (oconfig_item_t *ci)
        char *value = NULL;
 
        if ((0 != ci->children_num) || (1 != ci->values_num)
-                       || (OCONFIG_TYPE_STRING != ci->values[0].type)) {
-       }
+                       || (OCONFIG_TYPE_STRING != ci->values[0].type))
+               return 1;
 
        value = ci->values[0].value.string;
 
@@ -987,8 +987,8 @@ static int perl_config_includedir (oconfig_item_t *ci)
        char *value = NULL;
 
        if ((0 != ci->children_num) || (1 != ci->values_num)
-                       || (OCONFIG_TYPE_STRING != ci->values[0].type)) {
-       }
+                       || (OCONFIG_TYPE_STRING != ci->values[0].type))
+               return 1;
 
        value = ci->values[0].value.string;