Merge branch 'lt/fix-sol-pack'
authorJunio C Hamano <junkio@cox.net>
Tue, 4 Apr 2006 20:42:02 +0000 (13:42 -0700)
committerJunio C Hamano <junkio@cox.net>
Tue, 4 Apr 2006 20:42:02 +0000 (13:42 -0700)
* lt/fix-sol-pack:
  Use sigaction and SA_RESTART in read-tree.c; add option in Makefile.
  safe_fgets() - even more anal fgets()
  pack-objects: be incredibly anal about stdio semantics
  Fix Solaris stdio signal handling stupidities

1  2 
pack-objects.c
read-tree.c

diff --cc pack-objects.c
@@@ -1090,24 -901,29 +1106,30 @@@ int main(int argc, char **argv
        prepare_packed_git();
  
        if (progress) {
-               struct itimerval v;
-               v.it_interval.tv_sec = 1;
-               v.it_interval.tv_usec = 0;
-               v.it_value = v.it_interval;
-               signal(SIGALRM, progress_interval);
-               setitimer(ITIMER_REAL, &v, NULL);
                fprintf(stderr, "Generating pack...\n");
+               setup_progress_signal();
        }
  
-       while (fgets(line, sizeof(line), stdin) != NULL) {
+       for (;;) {
 -              unsigned int hash;
 -              char *p;
                unsigned char sha1[20];
  
 -              if (progress_update) {
 -                      fprintf(stderr, "Counting objects...%d\r", nr_objects);
 -                      progress_update = 0;
+               if (!fgets(line, sizeof(line), stdin)) {
+                       if (feof(stdin))
+                               break;
+                       if (!ferror(stdin))
+                               die("fgets returned NULL, not EOF, not error!");
+                       if (errno != EINTR)
+                               die("fgets: %s", strerror(errno));
+                       clearerr(stdin);
+                       continue;
+               }
 +              if (line[0] == '-') {
 +                      if (get_sha1_hex(line+1, sha1))
 +                              die("expected edge sha1, got garbage:\n %s",
 +                                  line+1);
 +                      add_preferred_base(sha1);
 +                      continue;
                }
                if (get_sha1_hex(line, sha1))
                        die("expected sha1, got garbage:\n %s", line);
diff --cc read-tree.c
Simple merge