Make "git-checkout" create files with O_EXCL

We should always have unlinked any old ones before, but this just makes
sure that we never over-write any old file.

A quick "grep" now shows that all the core tools that open files for
writing use O_EXCL, ie we never overwrite an existing file in place.

diff --git a/entry.c b/entry.c
index ded8310..792ea73 100644 (file)
--- a/entry.c
+++ b/entry.c
@@ -62,11 +62,11 @@ static int create_file(const char *path, unsigned int mode, int force)
        int fd;
 
        mode = (mode & 0100) ? 0777 : 0666;
-       fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, mode);
+       fd = open(path, O_WRONLY | O_TRUNC | O_CREAT | O_EXCL, mode);
        if (fd < 0) {
                if (errno == EISDIR && force) {
                        remove_subtree(path);
-                       fd = open(path, O_WRONLY | O_TRUNC | O_CREAT, mode);
+                       fd = open(path, O_WRONLY | O_TRUNC | O_CREAT | O_EXCL, mode);
                }
        }
        return fd;