X-Git-Url: https://git.verplant.org/?a=blobdiff_plain;f=src%2Ftarget_set.c;h=6115639b5bcd73679b41f4a5623b0f38b43cbd69;hb=82e59ce7eb02c78d911dac7663383ce372b79c90;hp=99f8aa6a53a9dc189dfa4520ee4f0059d57d373a;hpb=e030096e4f5a0bbdd42635bfeb95e39d150cac72;p=collectd.git diff --git a/src/target_set.c b/src/target_set.c index 99f8aa6a..6115639b 100644 --- a/src/target_set.c +++ b/src/target_set.c @@ -39,7 +39,7 @@ struct ts_data_s }; typedef struct ts_data_s ts_data_t; -int ts_util_get_key_and_string_wo_strdup (const oconfig_item_t *ci, char **ret_key, char **ret_string) /* {{{ */ +static int ts_util_get_key_and_string_wo_strdup (const oconfig_item_t *ci, char **ret_key, char **ret_string) /* {{{ */ { if ((ci->values_num != 2) || (ci->values[0].type != OCONFIG_TYPE_STRING) @@ -103,15 +103,17 @@ static int ts_config_add_meta (meta_data_t **dest, /* {{{ */ return (-1); } - if(NULL == (*dest)) { + if ((*dest) == NULL) + { // Create a new meta_data_t - if( NULL == (*dest = meta_data_create())) { + if ((*dest = meta_data_create()) == NULL) + { ERROR ("Target `set': failed to create a meta data for `%s'.", ci->key); return (-1); } } - return(meta_data_add_string (*dest, key, string)); + return (meta_data_add_string (*dest, key, string)); } /* }}} int ts_config_add_meta */ static int ts_destroy (void **user_data) /* {{{ */ @@ -237,7 +239,8 @@ static int ts_invoke (const data_set_t *ds, value_list_t *vl, /* {{{ */ return (-EINVAL); } - if(NULL != data->meta) { + if (data->meta != NULL) + { meta_data_clone_merge(&(vl->meta), data->meta); }