X-Git-Url: https://git.verplant.org/?a=blobdiff_plain;f=src%2Fpf.c;h=d7a5a15cff11b4cd3d2baf07297161fcc56867f3;hb=1bdfcf9791729310f75857d0e002c40ef659a89b;hp=d11bd8aaedabb6c2b5232009671007218156a0a3;hpb=594aa45c1df64eadae54c415524f3a267c12d7f8;p=collectd.git

diff --git a/src/pf.c b/src/pf.c
index d11bd8aa..d7a5a15c 100644
--- a/src/pf.c
+++ b/src/pf.c
@@ -20,6 +20,7 @@
  */
 
 #include "collectd.h"
+
 #include "plugin.h"
 #include "common.h"
 
@@ -29,6 +30,9 @@
 #if HAVE_NET_IF_H
 # include <net/if.h>
 #endif
+#if HAVE_NETINET_IN_H
+# include <netinet/in.h>
+#endif
 
 #include <net/pfvar.h>
 
@@ -79,7 +83,6 @@ static int pf_read (void)
 	struct pf_status state;
 	int fd;
 	int status;
-	int i;
 
 	fd = open (pf_device, O_RDONLY);
 	if (fd < 0)
@@ -91,7 +94,6 @@ static int pf_read (void)
 		return (-1);
 	}
 
-	memset (&state, 0, sizeof (state));
 	status = ioctl (fd, DIOCGETSTATUS, &state);
 	if (status != 0)
 	{
@@ -103,7 +105,6 @@ static int pf_read (void)
 	}
 
 	close (fd);
-	fd = -1;
 
 	if (!state.running)
 	{
@@ -111,16 +112,16 @@ static int pf_read (void)
 		return (-1);
 	}
 
-	for (i = 0; i < PFRES_MAX; i++)
+	for (int i = 0; i < PFRES_MAX; i++)
 		pf_submit ("pf_counters", pf_reasons[i], state.counters[i],
 				/* is gauge = */ 0);
-	for (i = 0; i < LCNT_MAX; i++)
+	for (int i = 0; i < LCNT_MAX; i++)
 		pf_submit ("pf_limits", pf_lcounters[i], state.lcounters[i],
 				/* is gauge = */ 0);
-	for (i = 0; i < FCNT_MAX; i++)
+	for (int i = 0; i < FCNT_MAX; i++)
 		pf_submit ("pf_state", pf_fcounters[i], state.fcounters[i],
 				/* is gauge = */ 0);
-	for (i = 0; i < SCNT_MAX; i++)
+	for (int i = 0; i < SCNT_MAX; i++)
 		pf_submit ("pf_source", pf_scounters[i], state.scounters[i],
 				/* is gauge = */ 0);