X-Git-Url: https://git.verplant.org/?a=blobdiff_plain;f=src%2Fliboconfig%2Foconfig.c;h=48f0b25f54dc57807931c82f6d437352d5e457da;hb=1ebf2f31bd2e080e6f42de640f0a3899a61501c0;hp=5d2c5b2afa7a7907b6a2e3139fcf7357f563f0ae;hpb=3aeca36659b04725028f123bcea387a37581624a;p=collectd.git diff --git a/src/liboconfig/oconfig.c b/src/liboconfig/oconfig.c index 5d2c5b2a..48f0b25f 100644 --- a/src/liboconfig/oconfig.c +++ b/src/liboconfig/oconfig.c @@ -55,7 +55,7 @@ oconfig_item_t *oconfig_parse_fh (FILE *fh) if (NULL == c_file) { status = snprintf (file, sizeof (file), "", fileno (fh)); - if ((status < 0) || (status >= sizeof (file))) { + if ((status < 0) || (((size_t) status) >= sizeof (file))) { c_file = ""; } else { @@ -106,7 +106,7 @@ oconfig_item_t *oconfig_clone (const oconfig_item_t *ci_orig) { oconfig_item_t *ci_copy; - ci_copy = (oconfig_item_t *) malloc (sizeof (*ci_copy)); + ci_copy = malloc (sizeof (*ci_copy)); if (ci_copy == NULL) { fprintf (stderr, "malloc failed.\n"); @@ -129,8 +129,8 @@ oconfig_item_t *oconfig_clone (const oconfig_item_t *ci_orig) { int i; - ci_copy->values = (oconfig_value_t *) calloc (ci_orig->values_num, - sizeof (*ci_copy->values)); + ci_copy->values = (oconfig_value_t *) calloc ((size_t) ci_orig->values_num, + sizeof (*ci_copy->values)); if (ci_copy->values == NULL) { fprintf (stderr, "calloc failed.\n"); @@ -145,18 +145,17 @@ oconfig_item_t *oconfig_clone (const oconfig_item_t *ci_orig) ci_copy->values[i].type = ci_orig->values[i].type; if (ci_copy->values[i].type == OCONFIG_TYPE_STRING) { - ci_copy->values[i].value.string - = strdup (ci_orig->values[i].value.string); - if (ci_copy->values[i].value.string == NULL) - { - fprintf (stderr, "strdup failed.\n"); - oconfig_free (ci_copy); - return (NULL); - } + ci_copy->values[i].value.string = strdup (ci_orig->values[i].value.string); + if (ci_copy->values[i].value.string == NULL) + { + fprintf (stderr, "strdup failed.\n"); + oconfig_free (ci_copy); + return (NULL); + } } else /* ci_copy->values[i].type != OCONFIG_TYPE_STRING) */ { - ci_copy->values[i].value = ci_orig->values[i].value; + ci_copy->values[i].value = ci_orig->values[i].value; } } } /* }}} if (ci_orig->values_num > 0) */ @@ -165,8 +164,8 @@ oconfig_item_t *oconfig_clone (const oconfig_item_t *ci_orig) { int i; - ci_copy->children = (oconfig_item_t *) calloc (ci_orig->children_num, - sizeof (*ci_copy->children)); + ci_copy->children = (oconfig_item_t *) calloc ((size_t) ci_orig->children_num, + sizeof (*ci_copy->children)); if (ci_copy->children == NULL) { fprintf (stderr, "calloc failed.\n");