X-Git-Url: https://git.verplant.org/?a=blobdiff_plain;f=src%2Fcollectdmon.c;h=13304f2a18075d2333c98c7daae66b64db8e766f;hb=290741f2e6de9e9b467463c1f0c6f031c4036428;hp=a5ed065d5340721cd484d60ebaf62c0a3ef0909d;hpb=9b1ae7f672fd2712b452a58e0682cdea2e34c0f8;p=collectd.git diff --git a/src/collectdmon.c b/src/collectdmon.c index a5ed065d..13304f2a 100644 --- a/src/collectdmon.c +++ b/src/collectdmon.c @@ -66,8 +66,8 @@ static int loop = 0; static int restart = 0; -static char *pidfile = NULL; -static pid_t collectd_pid = 0; +static const char *pidfile = NULL; +static pid_t collectd_pid = 0; __attribute__((noreturn)) static void exit_usage (const char *name) @@ -156,21 +156,24 @@ static int daemonize (void) dev_null = open ("/dev/null", O_RDWR); if (dev_null == -1) { - syslog (LOG_ERR, "Error: couldn't failed to open /dev/null: %s", strerror (errno)); + syslog (LOG_ERR, "Error: couldn't open /dev/null: %s", strerror (errno)); return -1; } if (dup2 (dev_null, STDIN_FILENO) == -1) { + close (dev_null); syslog (LOG_ERR, "Error: couldn't connect STDIN to /dev/null: %s", strerror (errno)); return -1; } if (dup2 (dev_null, STDOUT_FILENO) == -1) { + close (dev_null); syslog (LOG_ERR, "Error: couldn't connect STDOUT to /dev/null: %s", strerror (errno)); return -1; } if (dup2 (dev_null, STDERR_FILENO) == -1) { + close (dev_null); syslog (LOG_ERR, "Error: couldn't connect STDERR to /dev/null: %s", strerror (errno)); return -1; }