X-Git-Url: https://git.verplant.org/?a=blobdiff_plain;f=read-tree.c;h=f507f1633cf4a74ec5086ab8561684a03dbb9bd9;hb=e590d694ead8d50c2afc7086161d4ddc5d907655;hp=dc24e91b09b7468ca40d9142b18699b10193a2f6;hpb=4bb04f2190d526f8917663f0be62d8026e1ed100;p=git.git

diff --git a/read-tree.c b/read-tree.c
index dc24e91b..f507f163 100644
--- a/read-tree.c
+++ b/read-tree.c
@@ -5,6 +5,8 @@
  */
 #include "cache.h"
 
+static int stage = 0;
+
 static int read_one_entry(unsigned char *sha1, const char *base, int baselen, const char *pathname, unsigned mode)
 {
 	int len = strlen(pathname);
@@ -13,8 +15,8 @@ static int read_one_entry(unsigned char *sha1, const char *base, int baselen, co
 
 	memset(ce, 0, size);
 
-	ce->st_mode = mode;
-	ce->namelen = baselen + len;
+	ce->ce_mode = create_ce_mode(mode);
+	ce->ce_flags = create_ce_flags(baselen + len, stage);
 	memcpy(ce->name, base, baselen);
 	memcpy(ce->name + baselen, pathname, len+1);
 	memcpy(ce->sha1, sha1, 20);
@@ -71,6 +73,85 @@ static void remove_lock_file(void)
 		unlink(".git/index.lock");
 }
 
+static int same(struct cache_entry *a, struct cache_entry *b)
+{
+	return a->ce_mode == b->ce_mode && 
+		!memcmp(a->sha1, b->sha1, 20);
+}
+
+
+/*
+ * This removes all trivial merges that don't change the tree
+ * and collapses them to state 0.
+ *
+ * _Any_ other merge is left to user policy.  That includes "both
+ * created the same file", and "both removed the same file" - which are
+ * trivial, but the user might still want to _note_ it. 
+ */
+static struct cache_entry *merge_entries(struct cache_entry *a,
+					 struct cache_entry *b,
+					 struct cache_entry *c)
+{
+	int len = ce_namelen(a);
+
+	/*
+	 * Are they all the same filename? We won't do
+	 * any name merging
+	 */
+	if (ce_namelen(b) != len ||
+	    ce_namelen(c) != len ||
+	    memcmp(a->name, b->name, len) ||
+	    memcmp(a->name, c->name, len))
+		return NULL;
+
+	/*
+	 * Ok, all three entries describe the same
+	 * filename, but maybe the contents or file
+	 * mode have changed?
+	 *
+	 * The trivial cases end up being the ones where two
+	 * out of three files are the same:
+	 *  - both destinations the same, trivially take either
+	 *  - one of the destination versions hasn't changed,
+	 *    take the other.
+	 *
+	 * The "all entries exactly the same" case falls out as
+	 * a special case of any of the "two same" cases.
+	 *
+	 * Here "a" is "original", and "b" and "c" are the two
+	 * trees we are merging.
+	 */
+	if (same(b,c))
+		return c;
+	if (same(a,b))
+		return c;
+	if (same(a,c))
+		return b;
+	return NULL;
+}
+
+static void trivially_merge_cache(struct cache_entry **src, int nr)
+{
+	struct cache_entry **dst = src;
+
+	while (nr) {
+		struct cache_entry *ce, *result;
+
+		ce = src[0];
+		if (nr > 2 && (result = merge_entries(ce, src[1], src[2])) != NULL) {
+			ce = result;
+			ce->ce_flags &= ~htons(CE_STAGEMASK);
+			src += 2;
+			nr -= 2;
+			active_nr -= 2;
+		}
+		*dst = ce;
+		src++;
+		dst++;
+		nr--;
+	}
+}
+
 int main(int argc, char **argv)
 {
 	int i, newfd;
@@ -78,29 +159,31 @@ int main(int argc, char **argv)
 
 	newfd = open(".git/index.lock", O_RDWR | O_CREAT | O_EXCL, 0600);
 	if (newfd < 0)
-		usage("unable to create new cachefile");
+		die("unable to create new cachefile");
 	atexit(remove_lock_file);
 	remove_lock = 1;
 
 	for (i = 1; i < argc; i++) {
 		const char *arg = argv[i];
 
-		/* "-m" stands for "merge" current directory cache */
+		/* "-m" stands for "merge", meaning we start in stage 1 */
 		if (!strcmp(arg, "-m")) {
-			if (active_cache)
-				usage("read-tree: cannot merge old cache on top of new");
-			if (read_cache() < 0)
-				usage("read-tree: corrupt directory cache");
+			stage = 1;
 			continue;
 		}
 		if (get_sha1_hex(arg, sha1) < 0)
 			usage("read-tree [-m] <sha1>");
+		if (stage > 3)
+			usage("can't merge more than two trees");
 		if (read_tree(sha1, "", 0) < 0)
-			usage("failed to unpack tree object %s", arg);
+			die("failed to unpack tree object %s", arg);
+		stage++;
 	}
+	if (stage == 4)
+		trivially_merge_cache(active_cache, active_nr);
 	if (write_cache(newfd, active_cache, active_nr) ||
 	    rename(".git/index.lock", ".git/index"))
-		usage("unable to write new index file");
+		die("unable to write new index file");
 	remove_lock = 0;
 	return 0;
 }