X-Git-Url: https://git.verplant.org/?a=blobdiff_plain;f=lib%2Fspecial%2Fsprite.cpp;h=9bd8a989bfad1205770f7ece5d0e03884ea6561b;hb=f5849145d99db1e654d7219933672587a3d2f2e5;hp=f37e5eebbf999266a762d988e4c488e66ea0f672;hpb=332658f5f24460cc9533e9f42d67c5bb5ddd298d;p=supertux.git

diff --git a/lib/special/sprite.cpp b/lib/special/sprite.cpp
index f37e5eebb..9bd8a989b 100644
--- a/lib/special/sprite.cpp
+++ b/lib/special/sprite.cpp
@@ -39,6 +39,8 @@ Sprite::Sprite(lisp_object_t* cur)
       name = lisp_string(data);
     else if(token == "action")
       parse_action(reader);
+    else
+      std::cerr << "Warning: Unknown sprite field: " << token << std::endl;
     }
 
   if(name.empty())
@@ -68,8 +70,8 @@ Sprite::parse_action(LispReader& lispreader)
   if(!lispreader.read_string("name", action->name))
     if(!actions.empty())
       Termination::abort("Error: If there are more than one action, they need names!", "");
-  lispreader.read_int("x-hotspot", action->x_hotspot);
-  lispreader.read_int("y-hotspot", action->y_hotspot);
+  lispreader.read_int("x-offset", action->x_hotspot);
+  lispreader.read_int("y-offset", action->y_hotspot);
   lispreader.read_float("fps",     action->fps);
 
   std::vector<std::string> images;
@@ -92,22 +94,31 @@ Sprite::init_defaults(Action* act)
   act->y_hotspot = 0;
   act->fps = 10;
 
-  animation_loops = -1;
-  last_tick = 0;
+  start_animation(-1);
 }
 
 void
 Sprite::set_action(std::string act)
 {
+if(!next_action.empty() && animation_loops > 0)
+  {
+  next_action = act;
+  return;
+  }
 Actions::iterator i = actions.find(act);
+if(i == actions.end())
+  {
+  std::cerr << "Warning: Action '" << act << "' not found on Sprite '" << name << "'\n";
+  return;
+  }
 action = i->second;
 }
 
 void
 Sprite::start_animation(int loops)
 {
-animation_loops = loops;
 reset();
+animation_loops = loops;
 }
 
 void
@@ -116,6 +127,7 @@ Sprite::reset()
 frame = 0;
 last_tick = SDL_GetTicks();
 animation_reversed = false;
+next_action.clear();
 }
 
 bool
@@ -125,9 +137,9 @@ return animation_loops;
 }
 
 void
-Sprite::reverse_animation()
+Sprite::reverse_animation(bool reverse)
 {
-animation_reversed = !animation_reversed;
+animation_reversed = reverse;
 
 if(animation_reversed)
   frame = get_frames()-1;
@@ -142,38 +154,51 @@ if(animation_loops == 0)
   return;
 
 float frame_inc = (action->fps/1000.0) * (SDL_GetTicks() - last_tick);
+last_tick = SDL_GetTicks();
 
 if(animation_reversed)
   frame -= frame_inc;
 else
   frame += frame_inc;
 
-last_tick = SDL_GetTicks();
-
 if(animation_reversed)
   {
-  float expedient = frame - 0;
-  if(expedient < 0)
-    {
-    frame = get_frames()-1;
+  float excedent = frame - 0;
+  if((int)excedent < 0 || excedent >= get_frames())
+    {  // last case can happen when not used reverse_animation()
+    frame = get_frames() - 1;
     if(animation_loops > 0)
+      {
       animation_loops--;
-
-    if(expedient > -get_frames())
-      frame -= expedient;
+      if(animation_loops == 0 && !next_action.empty())
+        {
+        set_action(next_action);
+        start_animation(-1);
+        }
+      }
+
+    if(fabsf(excedent) < get_frames())
+      frame += excedent;
     }
   }
 else
   {
-  float expedient = frame - action->surfaces.size();
-  if(expedient >= 0)
+  float excedent = frame - action->surfaces.size();
+  if((int)excedent >= 0)
     {
     frame = 0;
     if(animation_loops > 0)
+      {
       animation_loops--;
-
-    if(expedient < get_frames())
-      frame += expedient;
+      if(animation_loops == 0 && !next_action.empty())
+        {
+        set_action(next_action);
+        start_animation(-1);
+        }
+      }
+
+    if(excedent < get_frames())
+      frame += excedent;
     }
   }
 }
@@ -185,7 +210,9 @@ Sprite::draw(DrawingContext& context, const Vector& pos, int layer,
   update();
 
   if((int)frame >= get_frames() || (int)frame < 0)
-    std::cerr << "Warning: frame higher than total frames or lower than 0!\n";
+    std::cerr << "Warning: frame out of range: " << (int)frame
+              << "/" << get_frames() << " at sprite: " << get_name()
+              << "/" << get_action_name() << std::endl;
   else
     context.draw_surface(action->surfaces[(int)frame],
             pos - Vector(action->x_hotspot, action->y_hotspot), layer, drawing_effect);