X-Git-Url: https://git.verplant.org/?a=blobdiff_plain;f=fsck-cache.c;h=32fa5d53e54f253720c165c6b3a5a6e1c4a44f9a;hb=de809dbbce497e0d107562615c1d85ff35b4e0c5;hp=d59d57ea76347c534908d2d7fa851044b1af4801;hpb=ace1534d6f3a710ed82e7e27ba1fe77c0c278695;p=git.git

diff --git a/fsck-cache.c b/fsck-cache.c
index d59d57ea..32fa5d53 100644
--- a/fsck-cache.c
+++ b/fsck-cache.c
@@ -62,6 +62,9 @@ static void check_connectivity(void)
  * So a directory called "a" is ordered _after_ a file
  * called "a.c", because "a/" sorts after "a.c".
  */
+#define TREE_UNORDERED (-1)
+#define TREE_HAS_DUPS  (-2)
+
 static int verify_ordered(struct tree_entry_list *a, struct tree_entry_list *b)
 {
 	int len1 = strlen(a->name);
@@ -74,7 +77,7 @@ static int verify_ordered(struct tree_entry_list *a, struct tree_entry_list *b)
 	if (cmp < 0)
 		return 0;
 	if (cmp > 0)
-		return -1;
+		return TREE_UNORDERED;
 
 	/*
 	 * Ok, the first <len> characters are the same.
@@ -83,11 +86,18 @@ static int verify_ordered(struct tree_entry_list *a, struct tree_entry_list *b)
 	 */
 	c1 = a->name[len];
 	c2 = b->name[len];
+	if (!c1 && !c2)
+		/*
+		 * git-write-tree used to write out a nonsense tree that has
+		 * entries with the same name, one blob and one tree.  Make
+		 * sure we do not have duplicate entries.
+		 */
+		return TREE_HAS_DUPS;
 	if (!c1 && a->directory)
 		c1 = '/';
 	if (!c2 && b->directory)
 		c2 = '/';
-	return c1 < c2 ? 0 : -1;
+	return c1 < c2 ? 0 : TREE_UNORDERED;
 }
 
 static int fsck_tree(struct tree *item)
@@ -123,10 +133,18 @@ static int fsck_tree(struct tree *item)
 		}
 
 		if (last) {
-			if (verify_ordered(last, entry) < 0) {
+			switch (verify_ordered(last, entry)) {
+			case TREE_UNORDERED:
 				fprintf(stderr, "tree %s not ordered\n",
 					sha1_to_hex(item->object.sha1));
 				return -1;
+			case TREE_HAS_DUPS:
+				fprintf(stderr, "tree %s has duplicate entries for '%s'\n",
+					sha1_to_hex(item->object.sha1),
+					entry->name);
+				return -1;
+			default:
+				break;
 			}
 		}
 
@@ -134,7 +152,7 @@ static int fsck_tree(struct tree *item)
 	}
 
 	if (has_full_path) {
-		fprintf(stderr, "warning: fsck-cache: tree %s "
+		fprintf(stderr, "warning: git-fsck-cache: tree %s "
 			"has full pathnames in it\n", 
 			sha1_to_hex(item->object.sha1));
 	}
@@ -278,6 +296,70 @@ static int fsck_dir(int i, char *path)
 	return 0;
 }
 
+static void read_sha1_reference(const char *path)
+{
+	char hexname[60];
+	unsigned char sha1[20];
+	int fd = open(path, O_RDONLY), len;
+	struct object *obj;
+
+	if (fd < 0)
+		return;
+
+	len = read(fd, hexname, sizeof(hexname));
+	close(fd);
+	if (len < 40)
+		return;
+
+	if (get_sha1_hex(hexname, sha1) < 0)
+		return;
+
+	obj = lookup_object(sha1);
+	obj->used = 1;
+	mark_reachable(obj, REACHABLE);
+}
+
+static void find_file_objects(const char *base, const char *name)
+{
+	int baselen = strlen(base);
+	int namelen = strlen(name);
+	char *path = xmalloc(baselen + namelen + 2);
+	struct stat st;
+
+	memcpy(path, base, baselen);
+	path[baselen] = '/';
+	memcpy(path + baselen + 1, name, namelen+1);
+	if (stat(path, &st) < 0)
+		return;
+
+	/*
+	 * Recurse into directories
+	 */
+	if (S_ISDIR(st.st_mode)) {
+		DIR *dir = opendir(path);
+		if (dir) {
+			struct dirent *de;
+			while ((de = readdir(dir)) != NULL) {
+				if (de->d_name[0] == '.')
+					continue;
+				find_file_objects(path, de->d_name);
+			}
+			closedir(dir);
+		}
+		return;
+	}
+	if (S_ISREG(st.st_mode)) {
+		read_sha1_reference(path);
+		return;
+	}
+}
+
+static void get_default_heads(void)
+{
+	char *git_dir = gitenv(GIT_DIR_ENVIRONMENT) ? : DEFAULT_GIT_DIR_ENVIRONMENT;
+	find_file_objects(git_dir, "refs");
+}
+
 int main(int argc, char **argv)
 {
 	int i, heads;
@@ -303,7 +385,7 @@ int main(int argc, char **argv)
 			continue;
 		}
 		if (*arg == '-')
-			usage("fsck-cache [--tags] [[--unreachable] [--cache] <head-sha1>*]");
+			usage("git-fsck-cache [--tags] [[--unreachable] [--cache] <head-sha1>*]");
 	}
 
 	sha1_dir = get_object_directory();
@@ -336,6 +418,16 @@ int main(int argc, char **argv)
 		error("expected sha1, got %s", arg);
 	}
 
+	/*
+	 * If we've not been gived any explicit head information, do the
+	 * default ones from .git/refs. We also consider the index file
+	 * in this case (ie this implies --cache).
+	 */
+	if (!heads) {
+		get_default_heads();
+		keep_cache_objects = 1;
+	}
+
 	if (keep_cache_objects) {
 		int i;
 		read_cache();
@@ -350,15 +442,6 @@ int main(int argc, char **argv)
 		}
 	}
 
-	if (!heads && !keep_cache_objects) {
-		if (show_unreachable) {
-			fprintf(stderr, "unable to do reachability without a head nor --cache\n");
-			show_unreachable = 0; 
-		}
-		if (!heads)
-			fprintf(stderr, "expect dangling commits - potential heads - due to lack of head information\n");
-	}
-
 	check_connectivity();
 	return 0;
 }