logfile plugin: Default to $localstatedir/log/collectd.log instead of STDOUT.

[collectd.git] / src / logfile.c

diff --git a/src/logfile.c b/src/logfile.c
index ceee7b8..f466124 100644 (file)
--- a/src/logfile.c
+++ b/src/logfile.c
@@ -26,6 +26,8 @@
 
 #include <pthread.h>
 
+#define DEFAULT_LOGFILE LOCALSTATEDIR"/log/collectd.log"
+
 #if COLLECT_DEBUG
 static int log_level = LOG_DEBUG;
 #else
@@ -35,11 +37,13 @@ static int log_level = LOG_INFO;
 static pthread_mutex_t file_lock = PTHREAD_MUTEX_INITIALIZER;
 
 static char *log_file = NULL;
+static int print_timestamp = 1;
 
 static const char *config_keys[] =
 {
        "LogLevel",
-       "File"
+       "File",
+       "Timestamp"
 };
 static int config_keys_num = STATIC_ARRAY_SIZE (config_keys);
 
@@ -66,18 +70,15 @@ static int logfile_config (const char *key, const char *value)
        }
        else if (0 == strcasecmp (key, "File")) {
                sfree (log_file);
-
-               if ((strcasecmp (value, "stdout") == 0)
-                               || (strcasecmp (value, "stderr") == 0)
-                               || (access (value, W_OK) == 0))
-                       log_file = strdup (value);
-               else {
-                       char errbuf[1024];
-                       /* We can't use `ERROR' yet.. */
-                       fprintf (stderr, "logfile plugin: Access to %s denied: %s\n",
-                                       value, sstrerror (errno, errbuf, sizeof (errbuf)));
-                       return 1;
-               }
+               log_file = strdup (value);
+       }
+       else if (0 == strcasecmp (key, "File")) {
+               if ((strcasecmp (value, "false") == 0)
+                               || (strcasecmp (value, "no") == 0)
+                               || (strcasecmp (value, "off") == 0))
+                       print_timestamp = 0;
+               else
+                       print_timestamp = 1;
        }
        else {
                return -1;
@@ -89,13 +90,31 @@ static void logfile_log (int severity, const char *msg)
 {
        FILE *fh;
        int do_close = 0;
+       time_t timestamp_time;
+       struct tm timestamp_tm;
+       char timestamp_str[64];
 
        if (severity > log_level)
                return;
 
+       if (print_timestamp)
+       {
+               timestamp_time = time (NULL);
+               localtime_r (&timestamp_time, &timestamp_tm);
+
+               strftime (timestamp_str, sizeof (timestamp_str), "%Y-%m-%d %H:%M:%S",
+                               &timestamp_tm);
+               timestamp_str[sizeof (timestamp_str) - 1] = '\0';
+       }
+
        pthread_mutex_lock (&file_lock);
 
-       if ((log_file == NULL) || (strcasecmp (log_file, "stderr") == 0))
+       if (log_file == NULL)
+       {
+               fh = fopen (DEFAULT_LOGFILE, "a");
+               do_close = 1;
+       }
+       else if (strcasecmp (log_file, "stderr") == 0)
                fh = stderr;
        else if (strcasecmp (log_file, "stdout") == 0)
                fh = stdout;
@@ -109,12 +128,16 @@ static void logfile_log (int severity, const char *msg)
        {
                        char errbuf[1024];
                        fprintf (stderr, "logfile plugin: fopen (%s) failed: %s\n",
-                                       (log_file == NULL) ? "<null>" : log_file,
+                                       (log_file == NULL) ? DEFAULT_LOGFILE : log_file,
                                        sstrerror (errno, errbuf, sizeof (errbuf)));
        }
        else
        {
-               fprintf (fh, "%s\n", msg);
+               if (print_timestamp)
+                       fprintf (fh, "[%s] %s\n", timestamp_str, msg);
+               else
+                       fprintf (fh, "%s\n", msg);
+
                if (do_close != 0)
                        fclose (fh);
        }
@@ -129,7 +152,6 @@ void module_register (void)
        plugin_register_config ("logfile", logfile_config,
                        config_keys, config_keys_num);
        plugin_register_log ("logfile", logfile_log);
-       return;
 } /* void module_register (void) */
 
 /* vim: set sw=4 ts=4 tw=78 noexpandtab : */