projects
/
collectd.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
src/daemon/utils_time.h: Use composite literals in all macros.
[collectd.git]
/
src
/
write_http.c
diff --git
a/src/write_http.c
b/src/write_http.c
index
95132cf
..
a7bb2e0
100644
(file)
--- a/
src/write_http.c
+++ b/
src/write_http.c
@@
-362,7
+362,11
@@
static int wh_write_command (const data_set_t *ds, const value_list_t *vl, /* {{
int status;
int status;
- if (0 != strcmp (ds->type, vl->type)) {
+ /* sanity checks, primarily to make static analyzers happy. */
+ if ((cb == NULL) || (cb->send_buffer == NULL))
+ return -1;
+
+ if (strcmp (ds->type, vl->type) == 0) {
ERROR ("write_http plugin: DS type does not match "
"value list type");
return -1;
ERROR ("write_http plugin: DS type does not match "
"value list type");
return -1;
@@
-415,6
+419,9
@@
static int wh_write_command (const data_set_t *ds, const value_list_t *vl, /* {{
}
assert (command_len < cb->send_buffer_free);
}
assert (command_len < cb->send_buffer_free);
+ /* Make scan-build happy. */
+ assert (cb->send_buffer != NULL);
+
/* `command_len + 1' because `command_len' does not include the
* trailing null byte. Neither does `send_buffer_fill'. */
memcpy (cb->send_buffer + cb->send_buffer_fill,
/* `command_len + 1' because `command_len' does not include the
* trailing null byte. Neither does `send_buffer_fill'. */
memcpy (cb->send_buffer + cb->send_buffer_fill,
@@
-813,13
+820,10
@@
static int wh_config_node (oconfig_item_t *ci) /* {{{ */
callback_name, cb->location);
user_data_t user_data = {
callback_name, cb->location);
user_data_t user_data = {
- .data = cb
+ .data = cb,
+ .free_func = wh_callback_free,
};
};
- plugin_register_flush (callback_name, wh_flush, &user_data);
-
- user_data.free_func = wh_callback_free;
-
if (cb->send_metrics)
{
plugin_register_write (callback_name, wh_write, &user_data);
if (cb->send_metrics)
{
plugin_register_write (callback_name, wh_write, &user_data);