projects
/
collectd.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
virt.c modifications to bring it in accordance with "octo" comments
[collectd.git]
/
src
/
powerdns.c
diff --git
a/src/powerdns.c
b/src/powerdns.c
index
f907d00
..
d7aa4e9
100644
(file)
--- a/
src/powerdns.c
+++ b/
src/powerdns.c
@@
-43,6
+43,7
@@
# define UNIX_PATH_MAX sizeof (((struct sockaddr_un *)0)->sun_path)
#endif
#define FUNC_ERROR(func) do { char errbuf[1024]; ERROR ("powerdns plugin: %s failed: %s", func, sstrerror (errno, errbuf, sizeof (errbuf))); } while (0)
# define UNIX_PATH_MAX sizeof (((struct sockaddr_un *)0)->sun_path)
#endif
#define FUNC_ERROR(func) do { char errbuf[1024]; ERROR ("powerdns plugin: %s failed: %s", func, sstrerror (errno, errbuf, sizeof (errbuf))); } while (0)
+#define SOCK_ERROR(func, sockpath) do { char errbuf[1024]; ERROR ("powerdns plugin: Socket `%s` %s failed: %s", sockpath, func, sstrerror (errno, errbuf, sizeof (errbuf))); } while (0)
#define SERVER_SOCKET LOCALSTATEDIR"/run/pdns.controlsocket"
#define SERVER_COMMAND "SHOW * \n"
#define SERVER_SOCKET LOCALSTATEDIR"/run/pdns.controlsocket"
#define SERVER_COMMAND "SHOW * \n"
@@
-300,10
+301,10
@@
static char *local_sockpath = NULL;
/* <https://doc.powerdns.com/md/recursor/stats/> */
static void submit (const char *plugin_instance, /* {{{ */
/* <https://doc.powerdns.com/md/recursor/stats/> */
static void submit (const char *plugin_instance, /* {{{ */
- const char *pdns_type, const char *value)
+ const char *pdns_type, const char *value
_str
)
{
value_list_t vl = VALUE_LIST_INIT;
{
value_list_t vl = VALUE_LIST_INIT;
- value_t value
s[1]
;
+ value_t value;
const char *type = NULL;
const char *type_instance = NULL;
const char *type = NULL;
const char *type_instance = NULL;
@@
-318,7
+319,7
@@
static void submit (const char *plugin_instance, /* {{{ */
if (i >= lookup_table_length)
{
INFO ("powerdns plugin: submit: Not found in lookup table: %s = %s;",
if (i >= lookup_table_length)
{
INFO ("powerdns plugin: submit: Not found in lookup table: %s = %s;",
- pdns_type, value);
+ pdns_type, value
_str
);
return;
}
return;
}
@@
-345,16
+346,15
@@
static void submit (const char *plugin_instance, /* {{{ */
return;
}
return;
}
- if (0 != parse_value (value
, &values[0]
, ds->ds[0].type))
+ if (0 != parse_value (value
_str, &value
, ds->ds[0].type))
{
ERROR ("powerdns plugin: Cannot convert `%s' "
{
ERROR ("powerdns plugin: Cannot convert `%s' "
- "to a number.", value);
+ "to a number.", value
_str
);
return;
}
return;
}
- vl.values =
values
;
+ vl.values =
&value
;
vl.values_len = 1;
vl.values_len = 1;
- sstrncpy (vl.host, hostname_g, sizeof (vl.host));
sstrncpy (vl.plugin, "powerdns", sizeof (vl.plugin));
sstrncpy (vl.type, type, sizeof (vl.type));
if (type_instance != NULL)
sstrncpy (vl.plugin, "powerdns", sizeof (vl.plugin));
sstrncpy (vl.type, type, sizeof (vl.type));
if (type_instance != NULL)
@@
-395,7
+395,7
@@
static int powerdns_get_data_dgram (list_item_t *item, /* {{{ */
status = unlink (sa_unix.sun_path);
if ((status != 0) && (errno != ENOENT))
{
status = unlink (sa_unix.sun_path);
if ((status != 0) && (errno != ENOENT))
{
-
FUNC_ERROR ("unlink"
);
+
SOCK_ERROR ("unlink", sa_unix.sun_path
);
close (sd);
return (-1);
}
close (sd);
return (-1);
}
@@
-407,7
+407,7
@@
static int powerdns_get_data_dgram (list_item_t *item, /* {{{ */
status = bind (sd, (struct sockaddr *) &sa_unix, sizeof (sa_unix));
if (status != 0)
{
status = bind (sd, (struct sockaddr *) &sa_unix, sizeof (sa_unix));
if (status != 0)
{
-
FUNC_ERROR ("bind"
);
+
SOCK_ERROR ("bind", sa_unix.sun_path
);
break;
}
break;
}
@@
-415,7
+415,7
@@
static int powerdns_get_data_dgram (list_item_t *item, /* {{{ */
status = chmod (sa_unix.sun_path, 0666);
if (status != 0)
{
status = chmod (sa_unix.sun_path, 0666);
if (status != 0)
{
-
FUNC_ERROR ("chmod"
);
+
SOCK_ERROR ("chmod", sa_unix.sun_path
);
break;
}
break;
}
@@
-428,7
+428,7
@@
static int powerdns_get_data_dgram (list_item_t *item, /* {{{ */
status = setsockopt (sd, SOL_SOCKET, SO_RCVTIMEO, &stv_timeout, sizeof (stv_timeout));
if (status != 0)
{
status = setsockopt (sd, SOL_SOCKET, SO_RCVTIMEO, &stv_timeout, sizeof (stv_timeout));
if (status != 0)
{
-
FUNC_ERROR ("setsockopt"
);
+
SOCK_ERROR ("setsockopt", sa_unix.sun_path
);
break;
}
break;
}
@@
-436,21
+436,21
@@
static int powerdns_get_data_dgram (list_item_t *item, /* {{{ */
sizeof (item->sockaddr));
if (status != 0)
{
sizeof (item->sockaddr));
if (status != 0)
{
-
FUNC_ERROR ("connect"
);
+
SOCK_ERROR ("connect", sa_unix.sun_path
);
break;
}
status = send (sd, item->command, strlen (item->command), 0);
if (status < 0)
{
break;
}
status = send (sd, item->command, strlen (item->command), 0);
if (status < 0)
{
-
FUNC_ERROR ("send"
);
+
SOCK_ERROR ("send", sa_unix.sun_path
);
break;
}
status = recv (sd, temp, sizeof (temp), /* flags = */ 0);
if (status < 0)
{
break;
}
status = recv (sd, temp, sizeof (temp), /* flags = */ 0);
if (status < 0)
{
-
FUNC_ERROR ("recv"
);
+
SOCK_ERROR ("recv", sa_unix.sun_path
);
break;
}
buffer_size = status + 1;
break;
}
buffer_size = status + 1;
@@
-513,7
+513,7
@@
static int powerdns_get_data_stream (list_item_t *item, /* {{{ */
sizeof (item->sockaddr));
if (status != 0)
{
sizeof (item->sockaddr));
if (status != 0)
{
-
FUNC_ERROR ("connect"
);
+
SOCK_ERROR ("connect", item->sockaddr.sun_path
);
close (sd);
return (-1);
}
close (sd);
return (-1);
}
@@
-523,7
+523,7
@@
static int powerdns_get_data_stream (list_item_t *item, /* {{{ */
/* flags = */ 0);
if (status < 0)
{
/* flags = */ 0);
if (status < 0)
{
-
FUNC_ERROR ("send"
);
+
SOCK_ERROR ("send", item->sockaddr.sun_path
);
close (sd);
return (-1);
}
close (sd);
return (-1);
}
@@
-535,7
+535,7
@@
static int powerdns_get_data_stream (list_item_t *item, /* {{{ */
status = recv (sd, temp, sizeof (temp), /* flags = */ 0);
if (status < 0)
{
status = recv (sd, temp, sizeof (temp), /* flags = */ 0);
if (status < 0)
{
-
FUNC_ERROR ("recv"
);
+
SOCK_ERROR ("recv", item->sockaddr.sun_path
);
break;
}
else if (status == 0)
break;
}
else if (status == 0)