- return a->ce_mode == b->ce_mode &&
- a->ce_mode == c->ce_mode &&
- ce_namelen(b) == len &&
- ce_namelen(c) == len &&
- !memcmp(a->name, b->name, len) &&
- !memcmp(a->name, c->name, len) &&
- !memcmp(a->sha1, b->sha1, 20) &&
- !memcmp(a->sha1, c->sha1, 20);
+
+ /*
+ * Are they all the same filename? We won't do
+ * any name merging
+ */
+ if (ce_namelen(b) != len ||
+ ce_namelen(c) != len ||
+ memcmp(a->name, b->name, len) ||
+ memcmp(a->name, c->name, len))
+ return NULL;
+
+ /*
+ * Ok, all three entries describe the same
+ * filename, but maybe the contents or file
+ * mode have changed?
+ *
+ * The trivial cases end up being the ones where two
+ * out of three files are the same:
+ * - both destinations the same, trivially take either
+ * - one of the destination versions hasn't changed,
+ * take the other.
+ *
+ * The "all entries exactly the same" case falls out as
+ * a special case of any of the "two same" cases.
+ *
+ * Here "a" is "original", and "b" and "c" are the two
+ * trees we are merging.
+ */
+ if (same(b,c))
+ return c;
+ if (same(a,b))
+ return c;
+ if (same(a,c))
+ return b;
+ return NULL;