collectd.git
6 years agoMerge branch 'master' into endian
Dagobert Michelsen [Tue, 3 Apr 2018 12:42:56 +0000 (14:42 +0200)]
Merge branch 'master' into endian

6 years agoInclude config.h early or _FILE_OFFSET_BITS is wrongly defined and bails out on Solar...
Dagobert Michelsen [Thu, 22 Mar 2018 13:54:01 +0000 (14:54 +0100)]
Include config.h early or _FILE_OFFSET_BITS is wrongly defined and bails out on Solaris 32 bit

6 years agoMerge pull request #2716 from dago/kstat
Ruben Kerkhof [Sat, 31 Mar 2018 10:18:39 +0000 (12:18 +0200)]
Merge pull request #2716 from dago/kstat

Include kstat.h when available

6 years agoMerge pull request #2688 from dstathis/master
Ruben Kerkhof [Sat, 31 Mar 2018 10:16:28 +0000 (12:16 +0200)]
Merge pull request #2688 from dstathis/master

change HAVE_UDEV_H to HAVE_LIBUDEV_H for bug 2651

6 years agoMerge pull request #2731 from elfiesmelfie/ovs_fixes
Ruben Kerkhof [Sat, 31 Mar 2018 09:17:08 +0000 (11:17 +0200)]
Merge pull request #2731 from elfiesmelfie/ovs_fixes

Ovs Fixes

6 years agoMerge remote-tracking branch 'origin/collectd-5.8'
Ruben Kerkhof [Fri, 30 Mar 2018 13:42:12 +0000 (15:42 +0200)]
Merge remote-tracking branch 'origin/collectd-5.8'

6 years agoAuto-Merge pull request #2736 from rpv-tomsk/collectd-collectd-5.8
collectd bot [Thu, 29 Mar 2018 19:17:13 +0000 (21:17 +0200)]
Auto-Merge pull request #2736 from rpv-tomsk/collectd-collectd-5.8

Automatically merged due to "Automerge" label

6 years agouuid plugin: Fixed hostname setting
Pavel Rochnyack [Thu, 29 Mar 2018 18:27:14 +0000 (01:27 +0700)]
uuid plugin: Fixed hostname setting

Closes: #2723
References: #2467

6 years agoMerge pull request #2722 from elfiesmelfie/increase_buffer
Pavel Rochnyak [Wed, 28 Mar 2018 15:28:12 +0000 (22:28 +0700)]
Merge pull request #2722 from elfiesmelfie/increase_buffer

dpdk: increase buffer size for parsing lcores

6 years agoMerge pull request #2721 from elfiesmelfie/update_README
Pavel Rochnyak [Wed, 28 Mar 2018 15:27:31 +0000 (22:27 +0700)]
Merge pull request #2721 from elfiesmelfie/update_README

README: Include compiler defenses suggestion

6 years agoMerge pull request #2703 from elfiesmelfie/fix_ipmi_bugfix_0.2
Pavel Rochnyak [Wed, 28 Mar 2018 15:26:21 +0000 (22:26 +0700)]
Merge pull request #2703 from elfiesmelfie/fix_ipmi_bugfix_0.2

Fixes for ipmi plugin

6 years agoMerge pull request #2704 from dhrupadb/patch-1
Pavel Rochnyak [Wed, 28 Mar 2018 14:39:24 +0000 (21:39 +0700)]
Merge pull request #2704 from dhrupadb/patch-1

Properly cleanup dropped MySQL connections.

6 years agoMerge pull request #2735 from rpv-tomsk/collectd-master
Pavel Rochnyak [Wed, 28 Mar 2018 14:17:48 +0000 (21:17 +0700)]
Merge pull request #2735 from rpv-tomsk/collectd-master

Tree wide: Replace sstrerror() with STRERRNO.

6 years agoTree wide: Replace sstrerror() with STRERRNO.
Pavel Rochnyack [Sat, 10 Feb 2018 11:40:06 +0000 (18:40 +0700)]
Tree wide: Replace sstrerror() with STRERRNO.

References: #2519

6 years agoutils_ovs: fix resource leaks
Kavanagh, Mark B [Tue, 27 Feb 2018 17:28:55 +0000 (17:28 +0000)]
utils_ovs: fix resource leaks

In ovs_db_init(), upon failure of either ovs_db_event_thread_init()
and/or ovs_db_poll_thread_init(), ovs_db_destroy() is invoked, in
order to release OVSDB data resources.

However, in the event that ovs_db_destroy() returns an error value,
some OVSDB resources are never released, and are consequently lost.

Resolve this issue by checking the return value of ovs_db_destroy()
and manually releasing the appropriate resources accordingly.

Fixes: 5a90d0e ("ovs_events: Address PR comments")
Signed-off-by: Kavanagh, Mark B <mark.b.kavanagh@intel.com>
6 years agoutils_ovs: fix potential NULL
Kavanagh, Mark B [Mon, 26 Feb 2018 17:08:31 +0000 (17:08 +0000)]
utils_ovs: fix potential NULL

In ovs_utils_get_map_value(), YAJL_GET_ARRAY may return a NULL
pointer, which is subsequently dereferenced. Ensure that the
pointer is non-NULL before proceeding.

Fixes: 12f6497 ("ovs_events: Add external ids as metadata")
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoutils_ovs: fix potential NULL-string dereference
Kavanagh, Mark B [Mon, 26 Feb 2018 16:12:26 +0000 (16:12 +0000)]
utils_ovs: fix potential NULL-string dereference

In ovs_utils_get_map_value(), a potential NULL-string, returned
by YAJL_GET_STRING(), is passed to strcmp, and subsequently
dereferenced. Ensure that said string is non-NULL.

Fixes: cb59d85 ("ovs_events: Fix plugin collectd config file")
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoovs_stats: fix potential NULL array dereference
Kavanagh, Mark B [Mon, 26 Feb 2018 14:49:00 +0000 (14:49 +0000)]
ovs_stats: fix potential NULL array dereference

In ovs_stats_update_bridge(), YAJL_GET_ARRAY() may return a NULL
pointer. Ensure that a non-NULL pointer is returned, before
attempting to dererence same.

Fixes: 4256753 ("ovs_events: fix scan-build warnings #2205")
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoutils_ovs: fix potential NULL dereference
Mark Kavanagh [Mon, 19 Feb 2018 16:39:31 +0000 (16:39 +0000)]
utils_ovs: fix potential NULL dereference

In ovs_utils_get_map_value(), YAJL_GET_ARRAY may return NULL,
which is subsequently dereferenced.

Ensure that the returned pointer is non-NULL before attempting
to dereference it.

Fixes: 12f6497 ("ovs_events: Add external ids as metadata")
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoovs_stats: fix memory leak
Mark Kavanagh [Thu, 22 Feb 2018 11:55:44 +0000 (11:55 +0000)]
ovs_stats: fix memory leak

In ovs_stats_plugin_config(), memory may be allocated from the heap,
but is not subsequently freed in the case of failure later in the
function.

Fixes: bcf9c48 ("ovs_stats plugin: Fix a memory leak.")
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoovs_stats: fix potential NULL-string dereference
Mark Kavanagh [Wed, 21 Feb 2018 16:15:01 +0000 (16:15 +0000)]
ovs_stats: fix potential NULL-string dereference

The YAJL_GET_STRING macro may return NULL; ensure that the returned
string is non-NULL, before passing it to ovs_stats_new_port(), within
the context of the ovs_stats_update_bridge() function.

Since this change introduces another return path, a single 'failure'
return point is introduced to ovs_stats_bridge().

Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoutils_ovs: fix potential strcmp() NULL ptr param
Mark Kavanagh [Mon, 19 Feb 2018 15:55:45 +0000 (15:55 +0000)]
utils_ovs: fix potential strcmp() NULL ptr param

YAJL_GET_STRING(array_values[0]) may return NULL if
array_values[0]->string is NULL; passing a NULL parameter to
strcmp() is not recommended, since the resultant behaviour may
be undefined.

Resolve the issue by adding a NULL check for the string returned
by YAJL_GET_STRING.

Fixes: cbq59d853 ("ovs_events: Fix plugin collectd config file")
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoovs_stats: fix potential NULL dereference
Mark Kavanagh [Mon, 19 Feb 2018 15:23:46 +0000 (15:23 +0000)]
ovs_stats: fix potential NULL dereference

ovs_stats_update_iface() passes a pointer to a potentially-NULL
string to sstrncpy(); this is obviously problematic.

Add a check to ensure that the relevant string is non-NULL.

Fixes: 1cc7599 ("ovs_stats plugin: Fix null dereference of "port".)
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoovs_stats: fix potential NULL dereference
Mark Kavanagh [Mon, 19 Feb 2018 13:48:12 +0000 (13:48 +0000)]
ovs_stats: fix potential NULL dereference

ovs_stats_new_port() accepts a character pointer, uuid, as a parameter,
and copies it into port->uuid. Later, this value is dereferenced in
ovs_stats_update_bridge(). If uuid was NULL, then a SEGV will occur.

Resolve this issue by checking if uuid is NULL in ovs_stats_new_port().

Fixes: 481984e ("ovs_stats: Implement OVS statistics plugin.")
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agoovs_events: fix potential NULL pointer dereference
Mark Kavanagh [Mon, 19 Feb 2018 13:06:36 +0000 (13:06 +0000)]
ovs_events: fix potential NULL pointer dereference

A potentially-NULL pointer to ovs_events_iface_info_t is defererenced
by an invocation of sizeof(), within ovs_events_get_iface_info().

Move the offending line, such that it is executed after the
NULL-pointer check.

Fixes: f6adec45 ("ovs_events: Fix notification metadata garbage.")
Signed-off-by: Mark Kavanagh <mark.b.kavanagh@intel.com>
6 years agodpdk: fix utils_dpdk.c clang issue
Kevin Laatz [Thu, 22 Mar 2018 17:23:06 +0000 (17:23 +0000)]
dpdk: fix utils_dpdk.c clang issue

This commit resolves the clang issue in src/utils_dpdk.c

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
6 years agoKeep clang-format happy
Dagobert Michelsen [Wed, 21 Mar 2018 21:23:07 +0000 (22:23 +0100)]
Keep clang-format happy

6 years agoAdd fallback for endianess conversion
Dagobert Michelsen [Wed, 21 Mar 2018 21:09:15 +0000 (22:09 +0100)]
Add fallback for endianess conversion

6 years agoInclude kstat.h when available
Dagobert Michelsen [Wed, 21 Mar 2018 20:22:45 +0000 (21:22 +0100)]
Include kstat.h when available

6 years agoREADME: Include compiler defenses suggestion
Kevin Laatz [Tue, 27 Feb 2018 13:21:44 +0000 (13:21 +0000)]
README: Include compiler defenses suggestion

This commit adds text in the README to advise users of the DPDK plugins to
use compiler defenses such as -fstack-protector.

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
6 years agodpdk: increase buffer size for parsing lcores
Harry van Haaren [Wed, 21 Mar 2018 15:33:00 +0000 (15:33 +0000)]
dpdk: increase buffer size for parsing lcores

This commit increases the size of the "high_str" buffer,
which is later used by the strncpy() function. Static analysis
showed that there was a potential issue in accessing this string
if the buffer is smaller.

Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
6 years agoDocs: use "its" vice "it's" where appropriate
William Pursell [Wed, 10 Jan 2018 00:35:00 +0000 (16:35 -0800)]
Docs: use "its" vice "it's" where appropriate

6 years agoMerge pull request #2711 from dago/kstat
Pavel Rochnyak [Thu, 15 Mar 2018 05:38:39 +0000 (12:38 +0700)]
Merge pull request #2711 from dago/kstat

Include kstat.h if available to provide kstat_ctl_t

6 years agoFix suggest by test clang-format
Dagobert Michelsen [Sat, 10 Mar 2018 18:04:14 +0000 (19:04 +0100)]
Fix suggest by test clang-format

6 years agoInclude kstat.h if available to provide kstat_ctl_t
Dagobert Michelsen [Sat, 10 Mar 2018 17:34:33 +0000 (18:34 +0100)]
Include kstat.h if available to provide kstat_ctl_t

6 years agoRevert "ipmi plugin: Ignore events from ignored sensors"
Mariusz Szafranski [Wed, 7 Mar 2018 09:58:43 +0000 (09:58 +0000)]
Revert "ipmi plugin: Ignore events from ignored sensors"

This reverts commit cd660c5b07b6f09d165435f240ca17d118a1e452.

6 years agoRevert "ipmi plugin: Remove duplicate/unused code and unneeded brackets."
Mariusz Szafranski [Wed, 7 Mar 2018 09:57:50 +0000 (09:57 +0000)]
Revert "ipmi plugin: Remove duplicate/unused code and unneeded brackets."

This reverts commit 8c9d64bf7615875b5030127b4df68a620e084f0d.

6 years agogrpc plugin: Fixed typo in an error message.
Sebastian Harl [Wed, 7 Mar 2018 08:04:05 +0000 (09:04 +0100)]
grpc plugin: Fixed typo in an error message.

6 years agoipmi plugin: Remove duplicate/unused code and unneeded brackets.
Mariusz Szafranski [Mon, 5 Mar 2018 15:04:10 +0000 (15:04 +0000)]
ipmi plugin: Remove duplicate/unused code and unneeded brackets.

Change-Id: Ia4298f75f59e697df25d05091adbb556b64869e1
Signed-off-by: Mariusz Szafranski <mariuszx.szafranski@intel.com>
6 years agoProperly cleanup dropped MySQL connections.
Dhrupad Bhardwaj [Thu, 1 Mar 2018 23:45:14 +0000 (18:45 -0500)]
Properly cleanup dropped MySQL connections.

6 years agoipmi plugin: Threshold event handler registration fix
Mariusz Szafranski [Thu, 1 Mar 2018 12:09:19 +0000 (12:09 +0000)]
ipmi plugin: Threshold event handler registration fix

This patch fixes registration of threshold event handler for
specific sensor types (e.g. 'System Airflow')

Change-Id: I437f3fe68fecf264adb32a4e2ef4ac214a7e87a4
Signed-off-by: Mariusz Szafranski <mariuszx.szafranski@intel.com>
6 years agoipmi plugin: Ignore events from ignored sensors
Mariusz Szafranski [Thu, 1 Mar 2018 12:08:47 +0000 (12:08 +0000)]
ipmi plugin: Ignore events from ignored sensors

Reading is disabled for ignored sensors. This fix it to also
ignore events from s4ensors on ignore list.

Change-Id: I705593c79274a00456a786698452cd3c1bae9872
Signed-off-by: Mariusz Szafranski <mariuszx.szafranski@intel.com>
6 years agoipmi plugin: Fix crash in ipmi.so (interval < 0.5)
Mariusz Szafranski [Thu, 1 Mar 2018 12:07:56 +0000 (12:07 +0000)]
ipmi plugin: Fix crash in ipmi.so (interval < 0.5)

Fixes crash (divide by 0) in ipmi.so when plugin related interval
set to 0.45 or less.

Change-Id: I3ac2282efdc005edefe92f870ac30417451c202c
Signed-off-by: Mariusz Szafranski <mariuszx.szafranski@intel.com>
6 years agobuild.sh: fix a few cosmetic issues
Ruben Kerkhof [Sat, 24 Feb 2018 10:04:41 +0000 (11:04 +0100)]
build.sh: fix a few cosmetic issues

6 years agobuild.sh: use consistent indentation
Ruben Kerkhof [Sat, 24 Feb 2018 10:03:10 +0000 (11:03 +0100)]
build.sh: use consistent indentation

6 years agobuild.sh: look in m4 dir for macro's
Ruben Kerkhof [Sat, 24 Feb 2018 10:01:11 +0000 (11:01 +0100)]
build.sh: look in m4 dir for macro's

This fixes #2674

6 years agoMerge branch 'collectd-5.8'
Ruben Kerkhof [Mon, 19 Feb 2018 15:14:24 +0000 (16:14 +0100)]
Merge branch 'collectd-5.8'

6 years agoMerge branch 'collectd-5.7' into collectd-5.8
Ruben Kerkhof [Mon, 19 Feb 2018 15:14:01 +0000 (16:14 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8

6 years agoMerge pull request #2692 from shastah/fix-readiness-spelling
Pavel Rochnyak [Sun, 18 Feb 2018 18:39:03 +0000 (01:39 +0700)]
Merge pull request #2692 from shastah/fix-readiness-spelling

s/readyness/readiness/

6 years agos/readyness/readiness/
Jakub Jankowski [Sat, 17 Feb 2018 22:49:10 +0000 (23:49 +0100)]
s/readyness/readiness/

Signed-off-by: Jakub Jankowski <shasta@toxcorp.com>
6 years agochange HAVE_UDEV_H to HAVE_LIBUDEV_H for bug 2651
Dylan Stephano-Shachter [Thu, 15 Feb 2018 21:37:33 +0000 (16:37 -0500)]
change HAVE_UDEV_H to HAVE_LIBUDEV_H for bug 2651

6 years agoMerge pull request #2687 from jeis2497052/master
Pavel Rochnyak [Wed, 14 Feb 2018 08:13:09 +0000 (15:13 +0700)]
Merge pull request #2687 from jeis2497052/master

Propose fix some typos

6 years agoPropose fix some typos
John Eismeier [Tue, 13 Feb 2018 18:52:43 +0000 (13:52 -0500)]
Propose fix some typos

6 years agoMerge pull request #2676 from elfiesmelfie/fix_intel_pmu_crash
Pavel Rochnyak [Mon, 12 Feb 2018 08:20:10 +0000 (15:20 +0700)]
Merge pull request #2676 from elfiesmelfie/fix_intel_pmu_crash

intel_pmu: fix for possible null pointer dereference

6 years agointel_pmu: fix for possible null pointer dereference
Kamil Wiatrowski [Mon, 5 Feb 2018 13:57:13 +0000 (13:57 +0000)]
intel_pmu: fix for possible null pointer dereference

Null pointer dereference could occur for invalid first hardware event.
In pmu_add_hw_events if the first event was not resolved, on the second
iteration the eventlist_last could be dereferenced to mark previous
event as group leader.

Change-Id: Ic2a2a3572d6835ca892d71f3e66812f356592d9e
Signed-off-by: Kamil Wiatrowski <kamilx.wiatrowski@intel.com>
6 years agoMerge pull request #2684 from rpv-tomsk/fix-2673
Pavel Rochnyak [Sat, 10 Feb 2018 11:23:08 +0000 (18:23 +0700)]
Merge pull request #2684 from rpv-tomsk/fix-2673

write_prometheus: Set SO_REUSEADDR on listening socket

6 years agoMerge pull request #2613 from elfiesmelfie/update_dpdk_note
Pavel Rochnyak [Sat, 10 Feb 2018 11:19:02 +0000 (18:19 +0700)]
Merge pull request #2613 from elfiesmelfie/update_dpdk_note

docs: update dpdkstats documentation

6 years agowrite_prometheus: Set SO_REUSEADDR on listening socket
Pavel Rochnyack [Sat, 10 Feb 2018 10:46:30 +0000 (17:46 +0700)]
write_prometheus: Set SO_REUSEADDR on listening socket

Otherwise Collectd fails to bind the socket after restart.

Thanks to Richard Weinberger and Brandon Hume for reporting.

Closes: #2570
Closes: #2673

6 years agoAuto-Merge pull request #2683 from rpv-tomsk/fix-2607
collectd bot [Sat, 10 Feb 2018 10:12:50 +0000 (11:12 +0100)]
Auto-Merge pull request #2683 from rpv-tomsk/fix-2607

Automatically merged due to "Automerge" label

6 years agowrite_kafka: 'rd_kafka_errno2err' is deprecated, fix failed builds
Pavel Rochnyack [Sat, 10 Feb 2018 09:20:41 +0000 (09:20 +0000)]
write_kafka: 'rd_kafka_errno2err' is deprecated, fix failed builds

Since librdkafka-0.11.0 applications should use rd_kafka_last_error()
to retrieve the error code from the legacy APIs.

Thanks to hikdo.

Closes: #2607
Closes: #2628
Closes: #2640

6 years agoUpdate BUILD.dpdkstat.md
Maryam Tahhan [Fri, 26 Jan 2018 11:41:57 +0000 (11:41 +0000)]
Update BUILD.dpdkstat.md

fixed trailing word "Version"

6 years agoMerge pull request #2660 from pbostley/master
Pavel Rochnyak [Wed, 24 Jan 2018 05:19:17 +0000 (12:19 +0700)]
Merge pull request #2660 from pbostley/master

Adding support for CDAB endian 32-bit modbus polls

6 years agoAdding documentation for the Modbus little endian modes where 32 bit values have...
PJ Bostley [Tue, 23 Jan 2018 22:33:23 +0000 (15:33 -0700)]
Adding documentation for the Modbus little endian modes where 32 bit values have thier registers swapped

6 years agoAdding support for CDAB endian 32-bit modbus polls
PJ Bostley [Sat, 20 Jan 2018 23:39:36 +0000 (16:39 -0700)]
Adding support for CDAB endian 32-bit modbus polls

6 years agoAuto-Merge pull request #2629 from rpv-tomsk/fix-2626
collectd bot [Tue, 19 Dec 2017 14:09:45 +0000 (15:09 +0100)]
Auto-Merge pull request #2629 from rpv-tomsk/fix-2626

Automatically merged due to "Automerge" label

6 years agoipmi plugin: Fix broken 'Sensor' configuration option
Pavel Rochnyack [Tue, 19 Dec 2017 13:30:12 +0000 (20:30 +0700)]
ipmi plugin: Fix broken 'Sensor' configuration option

6 years agoMerge pull request #2512 from Stackdriver/pri
Sebastian Harl [Fri, 15 Dec 2017 13:10:08 +0000 (14:10 +0100)]
Merge pull request #2512 from Stackdriver/pri

Replace zu with PRIsz and llu with PRIu64.

6 years agoMerge branch 'collectd-5.8'
Pavel Rochnyack [Thu, 14 Dec 2017 16:38:05 +0000 (23:38 +0700)]
Merge branch 'collectd-5.8'

6 years agoAuto-Merge pull request #2611 from rpv-tomsk/fix-2587
collectd bot [Thu, 14 Dec 2017 15:05:23 +0000 (16:05 +0100)]
Auto-Merge pull request #2611 from rpv-tomsk/fix-2587

Automatically merged due to "Automerge" label

6 years agotail plugin, latency: Fix regressions after #2535
Pavel Rochnyack [Sun, 10 Dec 2017 17:14:01 +0000 (17:14 +0000)]
tail plugin, latency: Fix regressions after #2535

 - Remove two fixed decimal places from type instance of percentiles
 - Recover accuracy of bounds in type instance of buckets
 + Allow (compared to state before #2535) to report percentiles with fractional values
 * Changed maximum length of reported type and type instance to 50 chars

References: #2535
Closes: #2587

6 years agodocs: dpdk extended the initial note
Maryam Tahhan [Tue, 12 Dec 2017 16:36:52 +0000 (16:36 +0000)]
docs: dpdk extended the initial note

6 years agodocs: update dpdkstats documentation
Maryam Tahhan [Mon, 11 Dec 2017 16:14:20 +0000 (16:14 +0000)]
docs: update dpdkstats documentation

Update the dpdkstats documentation to state that it shouldn't be used with
OVS-with-DPDK. The Open vSwitch plugins is what should be used.

Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
6 years agoAuto-Merge pull request #2612 from rpv-tomsk/collectd-5.8-memcached
collectd bot [Sun, 10 Dec 2017 21:10:59 +0000 (22:10 +0100)]
Auto-Merge pull request #2612 from rpv-tomsk/collectd-5.8-memcached

Automatically merged due to "Automerge" label

6 years agomemcached: Check for closed connection to avoid deadloop
Pavel Rochnyack [Sun, 10 Dec 2017 20:24:33 +0000 (03:24 +0700)]
memcached: Check for closed connection to avoid deadloop

Check for 'recv(...) == 0' condition was missing.

6 years agoAuto-Merge pull request #2610 from rpv-tomsk/fix-2609
collectd bot [Sun, 10 Dec 2017 16:17:05 +0000 (17:17 +0100)]
Auto-Merge pull request #2610 from rpv-tomsk/fix-2609

Automatically merged due to "Automerge" label

6 years agoprocesses plugin: Fix compilation when ps_delay() not used.
Pavel Rochnyack [Sun, 10 Dec 2017 15:06:00 +0000 (22:06 +0700)]
processes plugin: Fix compilation when ps_delay() not used.

Remove unused ps_delay() function when compiled without libtaskstats/libmnl

Closes: #2609

6 years agoMerge pull request #2598 from octo/ff/delayacct
Florian Forster [Fri, 8 Dec 2017 18:51:50 +0000 (19:51 +0100)]
Merge pull request #2598 from octo/ff/delayacct

processes plugin: Add support for Linux Delay Accounting.

6 years agoprocesses plugin: Use the new "delay_rate" type for Delay Accounting.
Florian Forster [Fri, 8 Dec 2017 08:39:59 +0000 (09:39 +0100)]
processes plugin: Use the new "delay_rate" type for Delay Accounting.

6 years agoprocesses plugin: Add the "delay-" prefix to type instances.
Florian Forster [Fri, 8 Dec 2017 07:28:35 +0000 (08:28 +0100)]
processes plugin: Add the "delay-" prefix to type instances.

This fixes a regression introduced in
17b81d4fa4eabbb7c029ccf424f43e4d89c27e35.

6 years agoprocesses plugin: Fix error message.
Florian Forster [Thu, 7 Dec 2017 21:20:28 +0000 (22:20 +0100)]
processes plugin: Fix error message.

6 years agoprocesses plugin: Make delay metric reporting less repetitive.
Florian Forster [Thu, 7 Dec 2017 20:51:22 +0000 (21:51 +0100)]
processes plugin: Make delay metric reporting less repetitive.

6 years agocontrib/systemd.collectd.service: Add the processes plugin.
Florian Forster [Thu, 7 Dec 2017 20:25:40 +0000 (21:25 +0100)]
contrib/systemd.collectd.service: Add the processes plugin.

6 years agoprocesses plugin: Check for the CAP_NET_ADMIN capability.
Florian Forster [Thu, 7 Dec 2017 20:20:40 +0000 (21:20 +0100)]
processes plugin: Check for the CAP_NET_ADMIN capability.

This allows us to print helpful error messages to the user if something
goes wrong.

6 years agoAuto-Merge pull request #2605 from maryamtahhan/feat_turbostat_report_skl
collectd bot [Thu, 7 Dec 2017 18:03:14 +0000 (19:03 +0100)]
Auto-Merge pull request #2605 from maryamtahhan/feat_turbostat_report_skl

Automatically merged due to "Automerge" label

6 years agoturbostat: Add support of reporting GPU power on SKL in turbostat
Gordon Kelly [Thu, 7 Dec 2017 17:08:14 +0000 (12:08 -0500)]
turbostat: Add support of reporting GPU power on SKL in turbostat

Change-Id: Icb57cf5ab116069b1e4d9580e248af1207e3282b

6 years agodf: fix memory leak in error case
Toshiaki Takahashi [Wed, 6 Dec 2017 12:19:41 +0000 (12:19 +0000)]
df: fix memory leak in error case

Because the memory of the STATANYFS list is not released
when the read callback function error occurs,
a memory leak may occur.
With this change, the memory is always released
by not returning in the loop.

Signed-off-by: Florian Forster <octo@collectd.org>
6 years agoMerge branch 'collectd-5.8'
Florian Forster [Thu, 7 Dec 2017 16:12:35 +0000 (17:12 +0100)]
Merge branch 'collectd-5.8'

6 years agoMerge branch 'collectd-5.7' into collectd-5.8
Florian Forster [Thu, 7 Dec 2017 16:10:05 +0000 (17:10 +0100)]
Merge branch 'collectd-5.7' into collectd-5.8

6 years agoMakefile.am: Fix out-of-tree builds.
Florian Forster [Thu, 7 Dec 2017 16:06:49 +0000 (17:06 +0100)]
Makefile.am: Fix out-of-tree builds.

Fixes: #2602

6 years agoprocesses plugin: Implement the "CollectDelayAccounting" option.
Florian Forster [Wed, 6 Dec 2017 21:24:34 +0000 (22:24 +0100)]
processes plugin: Implement the "CollectDelayAccounting" option.

6 years agosrc/utils_taskstats.[ch]: Add library for Linux Delay Accounting.
Florian Forster [Wed, 6 Dec 2017 21:03:52 +0000 (22:03 +0100)]
src/utils_taskstats.[ch]: Add library for Linux Delay Accounting.

6 years agoAuto-Merge pull request #2593 from octo/ff/grpc
collectd bot [Wed, 6 Dec 2017 10:12:13 +0000 (11:12 +0100)]
Auto-Merge pull request #2593 from octo/ff/grpc

Automatically merged due to "Automerge" label

6 years agoconfigure: Be more verbose about why the grpc plugin cannot be built.
Florian Forster [Wed, 6 Dec 2017 09:00:09 +0000 (10:00 +0100)]
configure: Be more verbose about why the grpc plugin cannot be built.

6 years agoconfigure: Improve detection of grpc_cpp_plugin.
Florian Forster [Wed, 6 Dec 2017 08:58:06 +0000 (09:58 +0100)]
configure: Improve detection of grpc_cpp_plugin.

When the `--with-libgrpc++=<path>` command line argument is given, add
`<path>/bin` to the search path for grpc_cpp_plugin.

6 years agoMerge branch 'master' into pri
Sean Campbell [Wed, 6 Dec 2017 00:05:08 +0000 (19:05 -0500)]
Merge branch 'master' into pri

6 years agoReplace zu with PRIu64 and llu with new macro, PRIsz, which will make it easier to...
campbellsean@google.com [Tue, 31 Oct 2017 16:21:08 +0000 (12:21 -0400)]
Replace zu with PRIu64 and llu with new macro, PRIsz, which will make it easier to make the code platform-independent.

6 years agoliboconfig: Coding style changes.
Florian Forster [Tue, 5 Dec 2017 15:58:29 +0000 (16:58 +0100)]
liboconfig: Coding style changes.

Mostly whitespace.

6 years agoliboconfig: Improve error handling.
Florian Forster [Tue, 5 Dec 2017 15:56:53 +0000 (16:56 +0100)]
liboconfig: Improve error handling.

  * Use the YYERROR macro instead of exit(3).
  * Remove newlines from strings passed to yyerror().
  * Change return valud or yyerror() from int to void.

6 years agoliboconfig: Check return values of calloc() and realloc().
Florian Forster [Tue, 5 Dec 2017 15:53:34 +0000 (16:53 +0100)]
liboconfig: Check return values of calloc() and realloc().

CID: 38123

6 years agoemail plugin: Avoid strtok_r to tokenize input.
Florian Forster [Tue, 5 Dec 2017 15:50:33 +0000 (16:50 +0100)]
email plugin: Avoid strtok_r to tokenize input.

Coverity (wrongly) thinks that "type" might have been NULL (since its
first argument is non-NULL, this cannot happen). It has a point about
insufficient NULL-ness checks, though, as "tmp" may very well be NULL and
we're passing it to atoi() which will likely not take this well.

CID: 37988