From d7c5c7b89d46b286c1829f4b39db9e9ccc7417a1 Mon Sep 17 00:00:00 2001 From: Ingo Ruhnke Date: Mon, 18 Aug 2014 03:24:39 +0200 Subject: [PATCH] Added m_ prefixes to TextureManager --- src/video/texture_manager.cpp | 56 +++++++++++++++++++++++-------------------- src/video/texture_manager.hpp | 15 ++++++++---- 2 files changed, 40 insertions(+), 31 deletions(-) diff --git a/src/video/texture_manager.cpp b/src/video/texture_manager.cpp index 27b3f97b5..3a5f84970 100644 --- a/src/video/texture_manager.cpp +++ b/src/video/texture_manager.cpp @@ -35,47 +35,47 @@ #endif TextureManager::TextureManager() : - image_textures() - ,surfaces() + m_image_textures() + ,m_surfaces() #ifdef HAVE_OPENGL - ,textures(), - saved_textures() + ,m_textures(), + m_saved_textures() #endif { } TextureManager::~TextureManager() { - for(ImageTextures::iterator i = image_textures.begin(); i != image_textures.end(); ++i) + for(ImageTextures::iterator i = m_image_textures.begin(); i != m_image_textures.end(); ++i) { if(!i->second.expired()) { log_warning << "Texture '" << i->first << "' not freed" << std::endl; } } - image_textures.clear(); + m_image_textures.clear(); - for(auto& surface : surfaces) + for(auto& surface : m_surfaces) { SDL_FreeSurface(surface.second); } - surfaces.clear(); + m_surfaces.clear(); } TexturePtr TextureManager::get(const std::string& _filename) { std::string filename = FileSystem::normalize(_filename); - ImageTextures::iterator i = image_textures.find(filename); + ImageTextures::iterator i = m_image_textures.find(filename); TexturePtr texture; - if(i != image_textures.end()) + if(i != m_image_textures.end()) texture = i->second.lock(); if(!texture) { texture = create_image_texture(filename); texture->cache_filename = filename; - image_textures[filename] = texture; + m_image_textures[filename] = texture; } return texture; @@ -92,23 +92,23 @@ TextureManager::get(const std::string& _filename, const Rect& rect) void TextureManager::reap_cache_entry(const std::string& filename) { - ImageTextures::iterator i = image_textures.find(filename); - assert(i != image_textures.end()); + ImageTextures::iterator i = m_image_textures.find(filename); + assert(i != m_image_textures.end()); assert(i->second.expired()); - image_textures.erase(i); + m_image_textures.erase(i); } #ifdef HAVE_OPENGL void TextureManager::register_texture(GLTexture* texture) { - textures.insert(texture); + m_textures.insert(texture); } void TextureManager::remove_texture(GLTexture* texture) { - textures.erase(texture); + m_textures.erase(texture); } #endif @@ -131,8 +131,8 @@ TextureManager::create_image_texture_raw(const std::string& filename, const Rect { SDL_Surface *image = nullptr; - Surfaces::iterator i = surfaces.find(filename); - if (i != surfaces.end()) + Surfaces::iterator i = m_surfaces.find(filename); + if (i != m_surfaces.end()) { image = i->second; } @@ -146,7 +146,7 @@ TextureManager::create_image_texture_raw(const std::string& filename, const Rect throw std::runtime_error(msg.str()); } - surfaces[filename] = image; + m_surfaces[filename] = image; } SDLSurfacePtr subimage(SDL_CreateRGBSurfaceFrom(static_cast(image->pixels) + @@ -250,11 +250,15 @@ TextureManager::save_textures() #endif glPixelStorei(GL_PACK_ALIGNMENT, 1); - for(Textures::iterator i = textures.begin(); i != textures.end(); ++i) { + + for(Textures::iterator i = m_textures.begin(); i != m_textures.end(); ++i) + { save_texture(*i); } - for(ImageTextures::iterator i = image_textures.begin(); - i != image_textures.end(); ++i) { + + for(ImageTextures::iterator i = m_image_textures.begin(); + i != m_image_textures.end(); ++i) + { save_texture(dynamic_cast(i->second.lock().get())); } } @@ -290,7 +294,7 @@ TextureManager::save_texture(GLTexture* texture) saved_texture.pixels); #endif - saved_textures.push_back(saved_texture); + m_saved_textures.push_back(saved_texture); glDeleteTextures(1, &(texture->get_handle())); texture->set_handle(0); @@ -311,8 +315,8 @@ TextureManager::reload_textures() #endif glPixelStorei(GL_UNPACK_ALIGNMENT, 1); - for(std::vector::iterator i = saved_textures.begin(); - i != saved_textures.end(); ++i) { + for(std::vector::iterator i = m_saved_textures.begin(); + i != m_saved_textures.end(); ++i) { SavedTexture& saved_texture = *i; GLuint handle; @@ -340,7 +344,7 @@ TextureManager::reload_textures() saved_texture.texture->set_handle(handle); } - saved_textures.clear(); + m_saved_textures.clear(); } #endif diff --git a/src/video/texture_manager.hpp b/src/video/texture_manager.hpp index 8124928f0..306b40ede 100644 --- a/src/video/texture_manager.hpp +++ b/src/video/texture_manager.hpp @@ -54,12 +54,15 @@ public: private: friend class Texture; - void reap_cache_entry(const std::string& filename); typedef std::map > ImageTextures; - ImageTextures image_textures; + ImageTextures m_image_textures; + typedef std::map Surfaces; - Surfaces surfaces; + Surfaces m_surfaces; + +private: + void reap_cache_entry(const std::string& filename); TexturePtr create_image_texture(const std::string& filename, const Rect& rect); @@ -73,8 +76,9 @@ private: TexturePtr create_dummy_texture(); #ifdef HAVE_OPENGL +private: typedef std::set Textures; - Textures textures; + Textures m_textures; struct SavedTexture { @@ -89,8 +93,9 @@ private: GLint wrap_s; GLint wrap_t; }; - std::vector saved_textures; + std::vector m_saved_textures; +private: void save_texture(GLTexture* texture); #endif }; -- 2.11.0