From ab3102b11b5b56d42c38e60090accad253c1a4a1 Mon Sep 17 00:00:00 2001 From: Tobias Markus Date: Sat, 14 Feb 2015 17:22:18 +0100 Subject: [PATCH 1/1] Remove bogus asserts, fixes Coverity #29378 and #29408 --- src/math/random_generator.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/math/random_generator.cpp b/src/math/random_generator.cpp index fe4086b04..6429c533c 100644 --- a/src/math/random_generator.cpp +++ b/src/math/random_generator.cpp @@ -87,11 +87,10 @@ int RandomGenerator::rand() { } int RandomGenerator::rand(int v) { - assert(v >= 0 && v <= RandomGenerator::rand_max); // illegal arg + assert(v >= 0); // illegal arg // remove biases, esp. when v is large (e.g. v == (rand_max/4)*3;) int rv, maxV =(RandomGenerator::rand_max / v) * v; - assert(maxV <= RandomGenerator::rand_max); while ((rv = RandomGenerator::random()) >= maxV) ; return rv % v; // mod it down to 0..(maxV-1) -- 2.11.0