From 2f8083194bee1ea05b189c2fd06090659986a54a Mon Sep 17 00:00:00 2001 From: Ruben Kerkhof Date: Tue, 13 Aug 2019 11:26:50 +0200 Subject: [PATCH] common.c: remove always true comparison ntohs() returns an uint16_t, which is always less than 65535 --- src/utils/common/common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/utils/common/common.c b/src/utils/common/common.c index 7cfd3109..2d961d43 100644 --- a/src/utils/common/common.c +++ b/src/utils/common/common.c @@ -1456,13 +1456,13 @@ int service_name_to_port_number(const char *service_name) { service_number = (int)ntohs(sa->sin6_port); } - if ((service_number > 0) && (service_number <= 65535)) + if (service_number > 0) break; } freeaddrinfo(ai_list); - if ((service_number > 0) && (service_number <= 65535)) + if (service_number > 0) return service_number; return -1; } /* int service_name_to_port_number */ -- 2.11.0