collectd.git
15 years agosrc/plugin.c: Fixed a typo.
Sebastian Harl [Wed, 18 Mar 2009 10:11:35 +0000 (11:11 +0100)]
src/plugin.c: Fixed a typo.

15 years agoonewire plugin: Make use of the `complex read' callbacks.
Florian Forster [Thu, 19 Mar 2009 16:40:46 +0000 (17:40 +0100)]
onewire plugin: Make use of the `complex read' callbacks.

The `Interval' option is not honored and can be used to set an arbitrary
interval for this plugin.

15 years agouptime plugin: Shuffle some preprocessor stuff around.
Florian Forster [Thu, 19 Mar 2009 13:21:16 +0000 (14:21 +0100)]
uptime plugin: Shuffle some preprocessor stuff around.

Fix some comments and possibly a Solaris bug, too.

15 years agobuild system: Add the new `uptime' plugin.
Florian Forster [Thu, 19 Mar 2009 12:51:50 +0000 (13:51 +0100)]
build system: Add the new `uptime' plugin.

15 years agouptime plugin: Add a plugin to measure the time a system has been running.
Marco Chiappero [Thu, 19 Mar 2009 12:30:32 +0000 (13:30 +0100)]
uptime plugin: Add a plugin to measure the time a system has been running.

Florian Forster ha scritto:
>Hi Marco,

Hi Florian,

> Checking the KSTAT_TYPE_NAMED twice (three times if you count the
> assertion) is of course not necessary. I suspect a copy'n'paste error ;)

Me too. Please remove the second one at least, kstat_read do not change
ks_type.

>A quick `grep' revealed that `get_kstat' is only used in two places, the
>memory and the swap plugin - both trying to figure out the pagesize. If
>you need something else than `KSTAT_TYPE_NAMED', I'd suggest to move the
>checks to a new function `get_kstat_pagesize' and use that function in
>the two plugins.

I went for the kstat.h only solution.
Ok, I'm attaching the code, please check the preprocessor directives for
the includes section, I don't much about defines created by the build
system and its names.
I'm using it right now on a linux machine, but I haven't tested yet on
Solaris and BSDs. Today I tried to compile it on OpenSolaris, but after
fighting with the packaging system and many other things I gave up and
decided I won't try anymore. So, since I'd like to say the plugin is
done after testing it, Solaris testers are wanted :P
As soon as I can I will edit the wiki page, but first I want to have a
closer look to the iptable plugin and see how many modifications are
needed for IPv6 and then have an opinion about the single vs. double
plugin approach.
See you soon :)

Regars,
Marco

15 years agoMerge branch 'collectd-4.6'
Florian Forster [Wed, 18 Mar 2009 17:41:27 +0000 (18:41 +0100)]
Merge branch 'collectd-4.6'

15 years agosnmp plugin: Use `complex reads', one for each host.
Florian Forster [Wed, 18 Mar 2009 17:39:57 +0000 (18:39 +0100)]
snmp plugin: Use `complex reads', one for each host.

This way the reads are sheduled by the global read threads, thread
handling can be removed completely and intervals which are not a
multiple of the global interval are possible.

15 years agomysql plugin: Use "mysql-$db" when registering a read callback.
Florian Forster [Wed, 18 Mar 2009 17:22:36 +0000 (18:22 +0100)]
mysql plugin: Use "mysql-$db" when registering a read callback.

15 years agomysql plugin: use plugin_register_complex_read
Doug MacEachern [Tue, 17 Mar 2009 20:44:08 +0000 (13:44 -0700)]
mysql plugin: use plugin_register_complex_read

Signed-off-by: Doug MacEachern <dougm@hyperic.com>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agoMerge branch 'master' of octo@verplant.org:/var/lib/git/collectd
Florian Forster [Wed, 18 Mar 2009 10:54:48 +0000 (11:54 +0100)]
Merge branch 'master' of octo@verplant.org:/var/lib/git/collectd

15 years agoconfigure: Prefixed cache-ids in AC_CACHE_CHECK with "c_cv_". collectd-4.6.2
Florian Forster [Wed, 18 Mar 2009 10:11:18 +0000 (11:11 +0100)]
configure: Prefixed cache-ids in AC_CACHE_CHECK with "c_cv_".

autoconf requires the string "_cv_" to be present in cache-ids.

This patch adds/changes `have_broken_perl_load_module' which was added
after 4.5.

15 years agoBumped version to 4.6.2; Updated ChangeLog.
Florian Forster [Wed, 18 Mar 2009 10:07:30 +0000 (11:07 +0100)]
Bumped version to 4.6.2; Updated ChangeLog.

15 years agomysql plugin: un-static-ize mysql connections
Doug MacEachern [Tue, 17 Mar 2009 15:12:56 +0000 (08:12 -0700)]
mysql plugin: un-static-ize mysql connections

Signed-off-by: Doug MacEachern <dougm@hyperic.com>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Tue, 17 Mar 2009 13:51:51 +0000 (14:51 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6

15 years agosrc/plugin.c: Fix an error message.
Florian Forster [Tue, 17 Mar 2009 13:41:45 +0000 (14:41 +0100)]
src/plugin.c: Fix an error message.

15 years agomysql plugin: Some changes to the configuration handling.
Florian Forster [Tue, 17 Mar 2009 13:30:02 +0000 (14:30 +0100)]
mysql plugin: Some changes to the configuration handling.

The member `instance' is used to determine whether or not to use ``legacy
mode'':
- If it is NULL, legacy mode is in action
- Otherwise, non-legacy mode should be used.

``legacy mode'' and ``non-legacy mode'' cannot be mixed: If at least one
database is defined in the ``new'' way, all options that'd be valid in
legacy mode will only trigger a warning.

15 years agoconfigure: Prefixed cache-ids in AC_CACHE_CHECK with "c_cv_".
Sebastian Harl [Tue, 10 Mar 2009 20:26:51 +0000 (21:26 +0100)]
configure: Prefixed cache-ids in AC_CACHE_CHECK with "c_cv_".

autoconf requires the string "_cv_" to be present in cache-ids.

15 years agoconfigfile, types_list: Improved error messages when handling "TypesDB".
Sebastian Harl [Tue, 10 Mar 2009 19:48:54 +0000 (20:48 +0100)]
configfile, types_list: Improved error messages when handling "TypesDB".

15 years agoMerge branch 'collectd-4.6' of /var/lib/git/collectd into collectd-4.6
Florian Forster [Tue, 17 Mar 2009 08:29:06 +0000 (09:29 +0100)]
Merge branch 'collectd-4.6' of /var/lib/git/collectd into collectd-4.6

15 years agomysql plugin: add support for multiple databases
Doug MacEachern [Mon, 16 Mar 2009 22:17:09 +0000 (15:17 -0700)]
mysql plugin: add support for multiple databases

Signed-off-by: Doug MacEachern <dougm@hyperic.com>
Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agosrc/plugin.[ch]: Pass an interval to `plugin_register_complex_read'.
Florian Forster [Mon, 16 Mar 2009 15:15:11 +0000 (16:15 +0100)]
src/plugin.[ch]: Pass an interval to `plugin_register_complex_read'.

15 years agosrc/plugin.c: Remove an unused variable.
Florian Forster [Mon, 16 Mar 2009 14:01:39 +0000 (15:01 +0100)]
src/plugin.c: Remove an unused variable.

15 years agosrc/liboping/liboping.c: Fix a problem with strict aliasing.
Florian Forster [Mon, 16 Mar 2009 08:38:42 +0000 (09:38 +0100)]
src/liboping/liboping.c: Fix a problem with strict aliasing.

Just remove the code since it's dead anyway.

Thanks to Alan Pevec <apevec at gmail.com> for pointing this out :)

15 years agosrc/filter_chain.c: Allow chains without a default target.
Florian Forster [Mon, 16 Mar 2009 08:31:04 +0000 (09:31 +0100)]
src/filter_chain.c: Allow chains without a default target.

This is how it's documented.

15 years agotimediff match: Register the correct match name.
Bruno Prémont [Mon, 16 Mar 2009 08:18:42 +0000 (09:18 +0100)]
timediff match: Register the correct match name.

15 years agosrc/utils_cache.c: Fix an error message.
Florian Forster [Mon, 16 Mar 2009 08:07:12 +0000 (09:07 +0100)]
src/utils_cache.c: Fix an error message.

15 years agosrc/plugin.c: Use a heap to schedule reads.
Florian Forster [Sun, 15 Mar 2009 23:02:55 +0000 (00:02 +0100)]
src/plugin.c: Use a heap to schedule reads.

With this change basically only timeout checks are triggered from the
global "read loop". This will allow each read function to be queried at
a different interval. This is currently not used, but will come in handy
in the future.

15 years agosrc/collectd.conf.in: Add `match_timediff'.
Florian Forster [Sun, 15 Mar 2009 22:40:20 +0000 (23:40 +0100)]
src/collectd.conf.in: Add `match_timediff'.

15 years agoMerge branch 'collectd-4.6'
Florian Forster [Sat, 14 Mar 2009 17:52:38 +0000 (18:52 +0100)]
Merge branch 'collectd-4.6'

15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Sat, 14 Mar 2009 17:52:19 +0000 (18:52 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6

15 years agoMerge branch 'collectd-4.5' of octo@verplant.org:/var/lib/git/collectd into collectd-4.5
Florian Forster [Sat, 14 Mar 2009 17:08:10 +0000 (18:08 +0100)]
Merge branch 'collectd-4.5' of octo@verplant.org:/var/lib/git/collectd into collectd-4.5

15 years agobind plugin: Actually handle RR cache numbers as `gauge'..
Bruno Prémont [Sat, 14 Mar 2009 17:06:58 +0000 (18:06 +0100)]
bind plugin: Actually handle RR cache numbers as `gauge'..

Hi Florian,

Well a working patch was even less trivial as the quick one from
yesterday evening.

Just using a gauge type is not sufficient (only 0 is written to RRD
files), it's also necessary to adjust the bind_xml_stats_handle_view()
as has been done for the memory statistics

Attached is a patch to bind.c (I skipped types.db) which fixes the
cache data collection.

In addition I attached a graph of the cache evolution and memory (for
memory it might be worth giving it an own type as it's not cumulative
at all)

Bruno

15 years agobind plugin: "Trivial patch" to make `rr cache' stats work.
Florian Forster [Sat, 14 Mar 2009 17:06:19 +0000 (18:06 +0100)]
bind plugin: "Trivial patch" to make `rr cache' stats work.

15 years agobind plugin: "Trivial patch" to make `rr cache' stats work.
Florian Forster [Sat, 14 Mar 2009 17:02:35 +0000 (18:02 +0100)]
bind plugin: "Trivial patch" to make `rr cache' stats work.

15 years agocontrib/collection3: Use {interface} in `if_octets' graphs.
Florian Forster [Sat, 14 Mar 2009 16:54:19 +0000 (17:54 +0100)]
contrib/collection3: Use {interface} in `if_octets' graphs.

15 years agocontrib/collection3: Add graph for `ps_cputime'.
Florian Forster [Sat, 14 Mar 2009 16:53:55 +0000 (17:53 +0100)]
contrib/collection3: Add graph for `ps_cputime'.

15 years agocontrib/collection3: Add the "height" parameter.
Florian Forster [Sat, 14 Mar 2009 12:31:00 +0000 (13:31 +0100)]
contrib/collection3: Add the "height" parameter.

15 years agosrc/common.c, memory plugin: Fix a potential problem under Solaris.
Florian Forster [Fri, 13 Mar 2009 17:23:20 +0000 (18:23 +0100)]
src/common.c, memory plugin: Fix a potential problem under Solaris.

When the kstat chain has been updated (and init is called again),
get_kstat should overwrite the existing kstat pointer thingy.

15 years agocontrib/collection3: Fix two minor issues.
Florian Forster [Fri, 13 Mar 2009 15:20:36 +0000 (16:20 +0100)]
contrib/collection3: Fix two minor issues.

15 years agocontrib/collection3: Add "Wirkleistung" graph.
Stefan Pfab [Fri, 13 Mar 2009 14:49:02 +0000 (15:49 +0100)]
contrib/collection3: Add "Wirkleistung" graph.

15 years agocontrib/collection3: Minor HTML work-around for some browsers.
Florian Forster [Fri, 13 Mar 2009 14:43:03 +0000 (15:43 +0100)]
contrib/collection3: Minor HTML work-around for some browsers.

15 years agocontrib/collection3: Update bin/json.cgi to use the JSON module.
Florian Forster [Fri, 13 Mar 2009 14:42:30 +0000 (15:42 +0100)]
contrib/collection3: Update bin/json.cgi to use the JSON module.

15 years agocontrib/collection3: Add graph for "Table space" graphs.
Florian Forster [Fri, 13 Mar 2009 14:39:38 +0000 (15:39 +0100)]
contrib/collection3: Add graph for "Table space" graphs.

15 years agocontrib/collecion3: Add graphs for `dns_opcode' and `io_octets'.
Florian Forster [Fri, 13 Mar 2009 14:34:30 +0000 (15:34 +0100)]
contrib/collecion3: Add graphs for `dns_opcode' and `io_octets'.

15 years agocontrib/collection3: Add the `index' to the parameters.
Florian Forster [Fri, 13 Mar 2009 14:30:54 +0000 (15:30 +0100)]
contrib/collection3: Add the `index' to the parameters.

15 years agosrc/liboping/test_liboping.c: Remove legacy file.
Florian Forster [Thu, 12 Mar 2009 07:56:36 +0000 (08:56 +0100)]
src/liboping/test_liboping.c: Remove legacy file.

15 years agoMerge branch 'ff/gmond'
Florian Forster [Mon, 9 Mar 2009 17:48:20 +0000 (18:48 +0100)]
Merge branch 'ff/gmond'

15 years agoMerge branch 'collectd-4.6'
Florian Forster [Mon, 9 Mar 2009 17:48:12 +0000 (18:48 +0100)]
Merge branch 'collectd-4.6'

15 years agorrdtool plugin: Beatify a debugging message.
Florian Forster [Mon, 9 Mar 2009 17:45:46 +0000 (18:45 +0100)]
rrdtool plugin: Beatify a debugging message.

15 years agogmond plugin: Add a configuration.
Florian Forster [Mon, 9 Mar 2009 17:45:06 +0000 (18:45 +0100)]
gmond plugin: Add a configuration.

15 years agogmond plugin: Add a plugin to receive Ganglia multicast traffic.
Florian Forster [Mon, 9 Mar 2009 15:39:09 +0000 (16:39 +0100)]
gmond plugin: Add a plugin to receive Ganglia multicast traffic.

15 years agoMerge branch 'sh/collectd-4.5' into sh/collectd-4.6
Sebastian Harl [Sat, 7 Mar 2009 17:03:42 +0000 (18:03 +0100)]
Merge branch 'sh/collectd-4.5' into sh/collectd-4.6

Conflicts:
contrib/collection3/lib/Collectd/Graph/Common.pm
src/postgresql_default.conf

15 years agopostgresql_default.conf: Make sure the "disk_io" query does not return NULLs.
Sebastian Harl [Sat, 7 Mar 2009 16:43:54 +0000 (17:43 +0100)]
postgresql_default.conf: Make sure the "disk_io" query does not return NULLs.

Starting with some version between 8.3.3 and 8.3.6, pg_statio_*_tables returns
NULL instead of 0 for statistics if no instance of the appropriate relation
exists. PQgetvalue() returns an empty string in that case which would then
result in error messages when udb_result_submit() tries to convert that to a
number.

Now, the "disk_io" query uses PostgreSQL's coalesce() function to make sure 0
is returned instead of NULL.

15 years agosrc/plugin.c: Remove an unused variable.
Florian Forster [Sat, 7 Mar 2009 11:22:10 +0000 (12:22 +0100)]
src/plugin.c: Remove an unused variable.

15 years agocontrib/exec-nagios.px: Make it possible to run the same script multiple times.
Tom Throckmorton [Fri, 6 Mar 2009 18:28:26 +0000 (19:28 +0100)]
contrib/exec-nagios.px: Make it possible to run the same script multiple times.

15 years agorrdtool plugin: Fix a possible race condition at startup.
Florian Forster [Fri, 6 Mar 2009 15:53:28 +0000 (16:53 +0100)]
rrdtool plugin: Fix a possible race condition at startup.

On a very busy system, if the network plugin was initialized before the
rrdtool plugin, `rrd_cache_insert' may be called before the RRDtool
plugin is initialized. It would then pass `cache == NULL' to
`c_avl_get', resulting in a segmentation fault.

15 years agocollectd.conf(5): Don't mix spaces and tabs in configuration examples.
Sebastian Harl [Thu, 5 Mar 2009 10:49:17 +0000 (11:49 +0100)]
collectd.conf(5): Don't mix spaces and tabs in configuration examples.

15 years agocontrib/collection3: Fix stacking with NAN values.
Florian Forster [Thu, 5 Mar 2009 08:41:35 +0000 (09:41 +0100)]
contrib/collection3: Fix stacking with NAN values.

Stacked values above NAN values were not drawn previously..

15 years agocontrib/collection3: Minor cleanups.
Florian Forster [Thu, 5 Mar 2009 08:35:50 +0000 (09:35 +0100)]
contrib/collection3: Minor cleanups.

15 years agocontrib/collection3: Add the "IgnoreUnknown" config option.
Florian Forster [Thu, 5 Mar 2009 08:35:28 +0000 (09:35 +0100)]
contrib/collection3: Add the "IgnoreUnknown" config option.

Used by the "GenericStacked" graphs.

15 years agocontrib/collection3: Add "Total" to "GenericIO" graphs.
Florian Forster [Thu, 5 Mar 2009 08:33:02 +0000 (09:33 +0100)]
contrib/collection3: Add "Total" to "GenericIO" graphs.

Using the RRDtool 1.2 VDEF syntax.

15 years agocontrib/collection3: Add the "DataDir" config option.
Florian Forster [Thu, 5 Mar 2009 08:30:06 +0000 (09:30 +0100)]
contrib/collection3: Add the "DataDir" config option.

15 years agocontrib/collection3/bin/.htaccess: s/SetHandler/AddHandler/
Florian Forster [Thu, 5 Mar 2009 07:57:29 +0000 (08:57 +0100)]
contrib/collection3/bin/.htaccess: s/SetHandler/AddHandler/

SetHandler doesn't accept a file extension.

15 years agocontrib/collection3/bin/.htaccess: Add file.
Florian Forster [Thu, 5 Mar 2009 07:51:51 +0000 (08:51 +0100)]
contrib/collection3/bin/.htaccess: Add file.

This has been missing. Wonder why nobody complained..?

15 years agopostgresql_default.conf: Added a short usage and copyright header.
Sebastian Harl [Wed, 4 Mar 2009 15:50:06 +0000 (16:50 +0100)]
postgresql_default.conf: Added a short usage and copyright header.

15 years agopostgresql plugin: Made variable names more self-explanatory.
Sebastian Harl [Wed, 4 Mar 2009 15:00:53 +0000 (16:00 +0100)]
postgresql plugin: Made variable names more self-explanatory.

Also, while I was at it, improved some error messages.

15 years agopostgresql_default.conf: Don't use the deprecated {Min,Max}PgVersion options.
Sebastian Harl [Wed, 4 Mar 2009 12:39:16 +0000 (13:39 +0100)]
postgresql_default.conf: Don't use the deprecated {Min,Max}PgVersion options.

15 years agocollectd.conf(5): Mention that `Oracle' doesn't like semicolons..
Florian Forster [Mon, 2 Mar 2009 14:30:11 +0000 (15:30 +0100)]
collectd.conf(5): Mention that `Oracle' doesn't like semicolons..

.. at the end of the SQL statement.

15 years agolibcollectdclient: Check if the file handle is valid before writing to it.
Florian Forster [Mon, 2 Mar 2009 14:27:12 +0000 (15:27 +0100)]
libcollectdclient: Check if the file handle is valid before writing to it.

And free allocated memory when connecting fails. Only assign anything to
the user-provided pointer if `lcc_connect' succeeds. This should make
error-handling much more straight-forward.

15 years agosnmp plugin: Added a note about a potential bug that needs fixing.
Florian Forster [Mon, 2 Mar 2009 08:49:22 +0000 (09:49 +0100)]
snmp plugin: Added a note about a potential bug that needs fixing.

Negative absolute (gauge) values may be casted to an unsigned integer
variable on their way throught he daemon, producing VERY HIGH tempera-
tures in winter..

15 years agoMerge branch 'bp/php-collection' into collectd-4.5
Florian Forster [Mon, 2 Mar 2009 08:31:37 +0000 (09:31 +0100)]
Merge branch 'bp/php-collection' into collectd-4.5

15 years agophp-collection: Add support for named graph lists as favorites
Bruno Prémont [Sun, 1 Mar 2009 21:20:10 +0000 (22:20 +0100)]
php-collection: Add support for named graph lists as favorites

php-collection: Add support for named graph lists as favorites

php-collection allowed saving and loading a list of graphs from a
cookie.
This patch changes loading/saving to provide support for naming
of favorite graph lists.
When saving a name has to be provided (up to 30 alphanumerical
characters includeing underscore and hyphen.
For loading a named list can be selected from a dropdown list (this list
is refreshed when it gets focus) of available favorites.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection/functions.php: Escape/avoid problematic characters in RRD commandline
Bruno Prémont [Sun, 1 Mar 2009 21:20:06 +0000 (22:20 +0100)]
php-collection/functions.php: Escape/avoid problematic characters in RRD commandline

php-collection/functions.php: Escape/avoid problematic characters in RRD commandline

rrdtool does not like '!' in variable names so replace them with '_'.
(bind plugin has them in a few type-instances and type-instance is used
as variable name by MetaGraphs)
Also escape rrdtool field seperators that might appear in file names.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection/definitions.php: Add MetaGraph definitions for bind plugin
Bruno Prémont [Sun, 1 Mar 2009 21:19:59 +0000 (22:19 +0100)]
php-collection/definitions.php: Add MetaGraph definitions for bind plugin

php-collection/definitions.php: Add MetaGraph definitions for bind plugin

Add metagraph definition and matching function for the various
types used by bind plugin.
Adjust the memory MetaGraph function to support bind memory statistics.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection/graph.php: Add missing error500() function
Bruno Prémont [Sun, 1 Mar 2009 21:19:49 +0000 (22:19 +0100)]
php-collection/graph.php: Add missing error500() function

php-collection/graph.php: Add missing error500() function

When a call to rrdtool fails or some other internal error occurs
a HTTP error with code 500 and matching error image should be
returned, added the missing error500() function which does this
the same way as error404() and error400() functions.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection: Fixes and multiple saved graph lists
Bruno Prémont [Sun, 1 Mar 2009 21:19:43 +0000 (22:19 +0100)]
php-collection: Fixes and multiple saved graph lists

php-collection/functions.php: Fix collectd_flush()

Some obsolete code in collectd_flush() caused PHP Notice errors
and prevented caused the function to return before attempting
to ask collectd to flush cache.

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agophp-collection/definitions.php: Add missing MetaGraph for tcp_connections
Bruno Prémont [Sun, 1 Mar 2009 21:19:37 +0000 (22:19 +0100)]
php-collection/definitions.php: Add missing MetaGraph for tcp_connections

php-collection/definitions.php: Add missing MetaGraph for tcp_connections

Add missing MetaGraph reference for tcp_connections and fix DS name
for the MetaGraph

Signed-off-by: Florian Forster <octo@huhu.verplant.org>
15 years agocontrib/php-collection: A few more bug-fixes to the graphing scripts.
Bruno Prémont [Mon, 2 Mar 2009 08:24:39 +0000 (09:24 +0100)]
contrib/php-collection: A few more bug-fixes to the graphing scripts.

This removes some obsolete code which prevents flush from working and adds
missing wrapper error500().

15 years agosrc/plugin.c, network, rrdtool: Improved thread shutdown.
Florian Forster [Sun, 1 Mar 2009 08:43:54 +0000 (09:43 +0100)]
src/plugin.c, network, rrdtool: Improved thread shutdown.

Just some comments, info messages and not assigning zero to pthread_t.

15 years agoping plugin: Add support for drop rate and standard deviation.
Florian Forster [Sun, 1 Mar 2009 08:42:33 +0000 (09:42 +0100)]
ping plugin: Add support for drop rate and standard deviation.

15 years agoREADME: Documented the `--with-fp-layout' configure option.
Florian Forster [Sat, 28 Feb 2009 14:40:45 +0000 (15:40 +0100)]
README: Documented the `--with-fp-layout' configure option.

15 years agosrc/collectd.conf.in: Only include very few standard plugins by default.
Florian Forster [Sat, 28 Feb 2009 13:14:23 +0000 (14:14 +0100)]
src/collectd.conf.in: Only include very few standard plugins by default.

Available but disabled by default plugins are listed with one hash
mark ("#") in front of them; unavailable plugins are listed with two hash
marks ("##") in front of them.

Plugins loaded by default are:

 - syslog || logfile
 - rrdtool || network || csv
 - cpu
 - interface
 - load
 - memory

15 years agoprotocols plugin: Add to configuration summary and collectd.conf.in.
Florian Forster [Sat, 28 Feb 2009 13:09:35 +0000 (14:09 +0100)]
protocols plugin: Add to configuration summary and collectd.conf.in.

15 years agoprotocols plugin: Add a plugin which collets protocol information.
Florian Forster [Sat, 28 Feb 2009 11:12:54 +0000 (12:12 +0100)]
protocols plugin: Add a plugin which collets protocol information.

Currently a Linux only plugin. This plugin collects information about
IP, TCP, UDP, etc.

Thanks to Ulf Zimmermann for his (indirect) suggestion ;)

15 years agoMerge branch 'ff/java'
Florian Forster [Sat, 28 Feb 2009 09:35:58 +0000 (10:35 +0100)]
Merge branch 'ff/java'

15 years agoMerge branch 'collectd-4.6'
Florian Forster [Sat, 28 Feb 2009 09:35:17 +0000 (10:35 +0100)]
Merge branch 'collectd-4.6'

15 years agoMerge branch 'collectd-4.5' into collectd-4.6
Florian Forster [Sat, 28 Feb 2009 09:35:04 +0000 (10:35 +0100)]
Merge branch 'collectd-4.5' into collectd-4.6

15 years agodns plugin: Don't pass a NULL pointer to `pcap_open_live'.
Florian Forster [Sat, 28 Feb 2009 09:29:08 +0000 (10:29 +0100)]
dns plugin: Don't pass a NULL pointer to `pcap_open_live'.

Although the documentation states clearly, that passing a NULL pointer
as device is okay and handled like "any", doing so will crash the daemon
on some systems, most notably *BSDs but Linux users have reported this
behavior, too.

This patch passes "any" when the pointer it NULL, which reportedly
resulted in a different behavior, but still crashing the daemon. We'll
keep trying ;)

15 years agooracle plugin: Fix type size issue under 64bit systems.
Florian Forster [Fri, 27 Feb 2009 13:09:12 +0000 (14:09 +0100)]
oracle plugin: Fix type size issue under 64bit systems.

Under 64bit systems, `ub4' is of a different size than `size_t', so that a
`(size_t *)' cannot be casted to a `(ub4 *)' automatically.

15 years agocontrib/oracle/create_schema.ddl: Add GPLv2 license information.
Florian Forster [Tue, 24 Feb 2009 10:42:35 +0000 (11:42 +0100)]
contrib/oracle/create_schema.ddl: Add GPLv2 license information.

In accordance with Roman Klesel,
<C937BDA691901BFAD72AFEF3@ganga.office.noris.de>

15 years agosrc/common.c: Fixed a race condition in check_create_dir().
Sebastian Harl [Tue, 24 Feb 2009 10:27:22 +0000 (11:27 +0100)]
src/common.c: Fixed a race condition in check_create_dir().

Between checking for the existence of a directory using stat() and creating
the directory using mkdir(), another thread might have already created the
directory thus causing mkdir() to fail with errno == EEXIST. This case is now
handled sanely, no longer causing the function (and thus some write callback)
to fail in this case.

Most likely, this only happens during startup when creating the data
directories - later, no two threads should try to create the same directory.

Interestingly enough, I frequently encountered this issue on a single core
machine.

15 years agocollectd.conf(5), collectd-java(5): Updated the documentation for the Java plugin.
Florian Forster [Tue, 24 Feb 2009 10:24:38 +0000 (11:24 +0100)]
collectd.conf(5), collectd-java(5): Updated the documentation for the Java plugin.

15 years agocollectd-java(5): Documented the `match' and `target' callbacks.
Florian Forster [Tue, 24 Feb 2009 09:53:43 +0000 (10:53 +0100)]
collectd-java(5): Documented the `match' and `target' callbacks.

15 years agobindings/java/: CollectdMatchFactoryInterface: Add more JavaDoc.
Florian Forster [Tue, 24 Feb 2009 09:13:11 +0000 (10:13 +0100)]
bindings/java/: CollectdMatchFactoryInterface: Add more JavaDoc.

15 years agobindings/java/: Unify inline documentation terms.
Florian Forster [Tue, 24 Feb 2009 09:12:45 +0000 (10:12 +0100)]
bindings/java/: Unify inline documentation terms.

s/function/method/

15 years agojava plugin: Add support for `target' callbacks.
Florian Forster [Tue, 24 Feb 2009 09:11:56 +0000 (10:11 +0100)]
java plugin: Add support for `target' callbacks.

With the ``do everything while in the configuration phase'' issues all
sorted out, this was actually kinda easy.

Matches and targets share a lot of code, so that the patch actually isn't
all that large..

Now, the Java plugin is feature-complete \o/

15 years agoMerge branch 'master' into ff/java
Florian Forster [Tue, 24 Feb 2009 09:16:19 +0000 (10:16 +0100)]
Merge branch 'master' into ff/java

15 years agoMerge branch 'collectd-4.6'
Florian Forster [Tue, 24 Feb 2009 09:15:52 +0000 (10:15 +0100)]
Merge branch 'collectd-4.6'

15 years agosrc/plugin.c: Assure that targets get dynamically allocated memory.
Florian Forster [Tue, 24 Feb 2009 09:08:29 +0000 (10:08 +0100)]
src/plugin.c: Assure that targets get dynamically allocated memory.

If targets want to replace the values, they will have to use dynamically
allocated memory. If they can't free the values, because the pointer
might point to statically allocated memory, memory will be lost.

Unfortunately stack allocation will not do, since we will then not be able
to detect multiple replacements.

To impose as little a performance issue as possible, the dynamic allo-
cation is only done when either chain is present. If the filter mecha-
nism is not used, the values will not be copied.

15 years agojava plugin: Add support for `match' callbacks.
Florian Forster [Mon, 23 Feb 2009 17:59:04 +0000 (18:59 +0100)]
java plugin: Add support for `match' callbacks.

Holy crap, that one needed some serious magic.. The problem is, that the
filter chains are created before the initialization functions are run.
Since the Java plugin used to initialize the JVM and load the classes in
the init function, the match callbacks were not available in time.

The behavior is now: Create the JVM as soon as the the first `LoadPlugin'
option is found and load and configure all Java plugins while in the
configuration phase. (I. e. exactly like C plugins.)

Phew, I've earned that beer now.