From: Matthias Runge <mrunge@redhat.com>
Date: Tue, 7 Jan 2020 07:52:41 +0000 (+0100)
Subject: Merge pull request #3350 from qingling128/master
X-Git-Url: https://git.octo.it/?a=commitdiff_plain;h=d56aca9a8efcc1e40ce0c7f4b1123aaa8d3115ab;hp=071568a48ad7b4fff84e40cb0c3c25ef17ab61ae;p=collectd.git

Merge pull request #3350 from qingling128/master

Fix unreachable clause where both tmp_plugin and tmp_plugin_instance are non-empty.
---

diff --git a/src/aggregation.c b/src/aggregation.c
index 2c8ef880..e2f8ff1c 100644
--- a/src/aggregation.c
+++ b/src/aggregation.c
@@ -194,17 +194,21 @@ static int agg_instance_create_name(agg_instance_t *inst, /* {{{ */
       sstrncpy(tmp_plugin_instance, agg->ident.plugin_instance,
                sizeof(tmp_plugin_instance));
 
+    // Both tmp_plugin and tmp_plugin_instance are empty.
     if ((strcmp("", tmp_plugin) == 0) && (strcmp("", tmp_plugin_instance) == 0))
       sstrncpy(inst->ident.plugin_instance, AGG_FUNC_PLACEHOLDER,
                sizeof(inst->ident.plugin_instance));
-    else if (strcmp("", tmp_plugin) != 0)
+    // tmp_plugin is non-empty, and tmp_plugin_instance is empty.
+    else if (strcmp("", tmp_plugin_instance) == 0)
       ssnprintf(inst->ident.plugin_instance,
                 sizeof(inst->ident.plugin_instance), "%s-%s", tmp_plugin,
                 AGG_FUNC_PLACEHOLDER);
-    else if (strcmp("", tmp_plugin_instance) != 0)
+    // tmp_plugin is empty, and tmp_plugin_instance is non-empty.
+    else if (strcmp("", tmp_plugin) == 0)
       ssnprintf(inst->ident.plugin_instance,
                 sizeof(inst->ident.plugin_instance), "%s-%s",
                 tmp_plugin_instance, AGG_FUNC_PLACEHOLDER);
+    // Both tmp_plugin and tmp_plugin_instance are non-empty.
     else
       ssnprintf(inst->ident.plugin_instance,
                 sizeof(inst->ident.plugin_instance), "%s-%s-%s", tmp_plugin,