From: Tobias Markus <tobbi@mozilla-uk.org>
Date: Sat, 14 Feb 2015 16:22:18 +0000 (+0100)
Subject: Remove bogus asserts, fixes Coverity #29378 and #29408
X-Git-Url: https://git.octo.it/?a=commitdiff_plain;h=ab3102b11b5b56d42c38e60090accad253c1a4a1;hp=821ebaf57c3c02c2d74a1b87055bb55d88d9ae70;p=supertux.git

Remove bogus asserts, fixes Coverity #29378 and #29408
---

diff --git a/src/math/random_generator.cpp b/src/math/random_generator.cpp
index fe4086b04..6429c533c 100644
--- a/src/math/random_generator.cpp
+++ b/src/math/random_generator.cpp
@@ -87,11 +87,10 @@ int RandomGenerator::rand() {
 }
 
 int RandomGenerator::rand(int v) {
-  assert(v >= 0 && v <= RandomGenerator::rand_max); // illegal arg
+  assert(v >= 0); // illegal arg
 
   // remove biases, esp. when v is large (e.g. v == (rand_max/4)*3;)
   int rv, maxV =(RandomGenerator::rand_max / v) * v;
-  assert(maxV <= RandomGenerator::rand_max);
   while ((rv = RandomGenerator::random()) >= maxV)
     ;
   return rv % v;                          // mod it down to 0..(maxV-1)