From: Sergey Vlasov Date: Wed, 21 Sep 2005 16:34:14 +0000 (+0400) Subject: [PATCH] fetch.c: Remove some duplicated code in process() X-Git-Tag: v0.99.8~88 X-Git-Url: https://git.octo.it/?a=commitdiff_plain;h=5de0bfffbc3e32ca3574987a350b984d4a899f2e;p=git.git [PATCH] fetch.c: Remove some duplicated code in process() It does not matter if we call prefetch() or set the TO_SCAN flag before or after adding the object to process_queue. However, doing it before object_list_insert() allows us to kill 3 lines of duplicated code. Signed-off-by: Sergey Vlasov Signed-off-by: Junio C Hamano --- diff --git a/fetch.c b/fetch.c index 390de99f..3074f5f3 100644 --- a/fetch.c +++ b/fetch.c @@ -138,18 +138,15 @@ static int process(struct object *obj) /* We already have it, so we should scan it now. */ if (obj->flags & TO_SCAN) return 0; - object_list_insert(obj, process_queue_end); - process_queue_end = &(*process_queue_end)->next; obj->flags |= TO_SCAN; - return 0; + } else { + if (obj->flags & COMPLETE) + return 0; + prefetch(obj->sha1); } - if (obj->flags & COMPLETE) - return 0; + object_list_insert(obj, process_queue_end); process_queue_end = &(*process_queue_end)->next; - - prefetch(obj->sha1); - return 0; }