From: Jan-Philipp Litza Date: Fri, 9 Aug 2019 20:06:56 +0000 (+0200) Subject: zfs_arc: Fix skipping of leading lines X-Git-Url: https://git.octo.it/?a=commitdiff_plain;h=0cc3044fa6ecab59ad20be0504651e3f7f62006a;p=collectd.git zfs_arc: Fix skipping of leading lines Probably due to a merge gone wrong, the first two lines were skipped twice, skipping four lines in total and thus missing the "hits" and "misses" counts. --- diff --git a/src/zfs_arc.c b/src/zfs_arc.c index a3c24516..be93b9db 100644 --- a/src/zfs_arc.c +++ b/src/zfs_arc.c @@ -231,23 +231,6 @@ static int za_read(void) { return -1; } - // Ignore the first two lines because they contain information about - // the rest of the file. - // See kstat_seq_show_headers module/spl/spl-kstat.c of the spl kernel - // module. - if (fgets(buffer, sizeof(buffer), fh) == NULL) { - ERROR("zfs_arc plugin: \"%s\" does not contain a single line.", - ZOL_ARCSTATS_FILE); - fclose(fh); - return (-1); - } - if (fgets(buffer, sizeof(buffer), fh) == NULL) { - ERROR("zfs_arc plugin: \"%s\" does not contain at least two lines.", - ZOL_ARCSTATS_FILE); - fclose(fh); - return (-1); - } - while (fgets(buffer, sizeof(buffer), fh) != NULL) { char *fields[3]; value_t v;