python: Fix double-free bug.
authorSven Trenkel <collectd@semidefinite.de>
Sun, 4 Oct 2015 00:05:24 +0000 (00:05 +0000)
committerMarc Fournier <marc.fournier@camptocamp.com>
Wed, 7 Oct 2015 20:18:27 +0000 (22:18 +0200)
src/python.c

index 10ac8f0..95240af 100644 (file)
@@ -289,7 +289,7 @@ void cpy_log_exception(const char *context) {
                Py_XDECREF(traceback);
                return;
        }
-       list = PyObject_CallFunction(cpy_format_exception, "NNN", type, value, traceback); /* New reference. */
+       list = PyObject_CallFunction(cpy_format_exception, "NNN", type, value, traceback); /* New reference. Steals references from "type", "value" and "traceback". */
        if (list)
                l = PyObject_Length(list);
        for (i = 0; i < l; ++i) {
@@ -309,9 +309,6 @@ void cpy_log_exception(const char *context) {
        }
        Py_XDECREF(list);
        PyErr_Clear();
-       Py_DECREF(type);
-       Py_XDECREF(value);
-       Py_XDECREF(traceback);
 }
 
 static int cpy_read_callback(user_data_t *data) {