Merge pull request #1582 from rubenk/missing-prototypes

Missing prototypes

diff --git a/src/battery.c b/src/battery.c
index 4178d8b..d921484 100644 (file)
--- a/src/battery.c
+++ b/src/battery.c
@@ -111,7 +111,7 @@ static void battery_submit (const char *plugin_instance, const char *type, doubl
 } /* void battery_submit */
 
 #if HAVE_IOKIT_PS_IOPOWERSOURCES_H || HAVE_IOKIT_IOKITLIB_H
-double dict_get_double (CFDictionaryRef dict, char *key_string)
+static double dict_get_double (CFDictionaryRef dict, char *key_string)
 {
        double      val_double;
        long long   val_int;

diff --git a/src/liboconfig/oconfig.c b/src/liboconfig/oconfig.c
index 56ccefb..936e373 100644 (file)
--- a/src/liboconfig/oconfig.c
+++ b/src/liboconfig/oconfig.c
@@ -188,7 +188,7 @@ oconfig_item_t *oconfig_clone (const oconfig_item_t *ci_orig)
   return (ci_copy);
 } /* oconfig_item_t *oconfig_clone */
 
-void oconfig_free_all (oconfig_item_t *ci)
+static void oconfig_free_all (oconfig_item_t *ci)
 {
   int i;
 

diff --git a/src/plugin.h b/src/plugin.h
index 8f0c6d8..d54db4b 100644 (file)
--- a/src/plugin.h
+++ b/src/plugin.h
@@ -399,4 +399,10 @@ cdtime_t plugin_get_interval (void);
 int plugin_thread_create (pthread_t *thread, const pthread_attr_t *attr,
                void *(*start_routine) (void *), void *arg);
 
+/*
+ * Plugins need to implement this
+ */
+
+void module_register (void);
+
 #endif /* PLUGIN_H */

diff --git a/src/processes.c b/src/processes.c
index c516208..0742a20 100644 (file)
--- a/src/processes.c
+++ b/src/processes.c
@@ -922,7 +922,7 @@ static procstat_t *ps_read_io (long pid, procstat_t *ps)
        return (ps);
 } /* procstat_t *ps_read_io */
 
-int ps_read_process (long pid, procstat_t *ps, char *state)
+static int ps_read_process (long pid, procstat_t *ps, char *state)
 {
        char  filename[64];
        char  buffer[1024];

diff --git a/src/sensors.c b/src/sensors.c
index 209482e..37d335c 100644 (file)
--- a/src/sensors.c
+++ b/src/sensors.c
@@ -262,7 +262,7 @@ static int sensors_config (const char *key, const char *value)
        return (0);
 }
 
-void sensors_free_features (void)
+static void sensors_free_features (void)
 {
        featurelist_t *thisft;
        featurelist_t *nextft;

diff --git a/src/threshold.c b/src/threshold.c
index a70ec8a..c1af40b 100644 (file)
--- a/src/threshold.c
+++ b/src/threshold.c
@@ -958,7 +958,7 @@ static int ut_missing (const value_list_t *vl,
   return (0);
 } /* }}} int ut_missing */
 
-int ut_config (oconfig_item_t *ci)
+static int ut_config (oconfig_item_t *ci)
 { /* {{{ */
   int i;
   int status = 0;

diff --git a/src/types_list.c b/src/types_list.c
index 887b43d..41bb403 100644 (file)
--- a/src/types_list.c
+++ b/src/types_list.c
@@ -24,6 +24,7 @@
 
 #include "plugin.h"
 #include "configfile.h"
+#include "types_list.h"
 
 static int parse_ds (data_source_t *dsrc, char *buf, size_t buf_len)
 {

diff --git a/src/utils_cmd_flush.c b/src/utils_cmd_flush.c
index 9a59310..087fee3 100644 (file)
--- a/src/utils_cmd_flush.c
+++ b/src/utils_cmd_flush.c
@@ -25,6 +25,7 @@
 #include "common.h"
 #include "plugin.h"
 #include "utils_parse_option.h"
+#include "utils_cmd_flush.h"
 
 int handle_flush (FILE *fh, char *buffer)
 {

diff --git a/src/utils_cmd_getval.c b/src/utils_cmd_getval.c
index 657483b..8d214aa 100644 (file)
--- a/src/utils_cmd_getval.c
+++ b/src/utils_cmd_getval.c
@@ -25,6 +25,7 @@
 
 #include "utils_cache.h"
 #include "utils_parse_option.h"
+#include "utils_cmd_getval.h"
 
 #define print_to_socket(fh, ...) \
   do { \

diff --git a/src/utils_cmd_putnotif.c b/src/utils_cmd_putnotif.c
index bed8462..ec91419 100644 (file)
--- a/src/utils_cmd_putnotif.c
+++ b/src/utils_cmd_putnotif.c
@@ -24,6 +24,7 @@
 #include "plugin.h"
 
 #include "utils_parse_option.h"
+#include "utils_cmd_putnotif.h"
 
 #define print_to_socket(fh, ...) \
   do { \

diff --git a/src/utils_cmd_putval.c b/src/utils_cmd_putval.c
index c9bf48b..a0d20c5 100644 (file)
--- a/src/utils_cmd_putval.c
+++ b/src/utils_cmd_putval.c
@@ -24,6 +24,7 @@
 #include "plugin.h"
 
 #include "utils_parse_option.h"
+#include "utils_cmd_putval.h"
 
 #define print_to_socket(fh, ...) \
     do { \

diff --git a/src/utils_db_query.c b/src/utils_db_query.c
index e8d7b3a..6b3c056 100644 (file)
--- a/src/utils_db_query.c
+++ b/src/utils_db_query.c
@@ -543,7 +543,7 @@ static int udb_result_create (const char *query_name, /* {{{ */
 /*
  * Query private functions
  */
-void udb_query_free_one (udb_query_t *q) /* {{{ */
+static void udb_query_free_one (udb_query_t *q) /* {{{ */
 {
   if (q == NULL)
     return;

diff --git a/src/utils_latency.c b/src/utils_latency.c
index 9047974..efca6d2 100644 (file)
--- a/src/utils_latency.c
+++ b/src/utils_latency.c
@@ -24,14 +24,14 @@
  *   Florian Forster <ff at octo.it>
  **/
 
+#include <math.h>
+#include <limits.h>
+
 #include "collectd.h"
 #include "plugin.h"
 #include "utils_latency.h"
 #include "common.h"
 
-#include <math.h>
-#include <limits.h>
-
 #ifndef LLONG_MAX
 # define LLONG_MAX 9223372036854775807LL
 #endif
@@ -76,7 +76,7 @@ struct latency_counter_s
 * So, if the required bin width is 300, then new bin width will be 512 as it is
 * the next nearest power of 2.
 */
-void change_bin_width (latency_counter_t *lc, cdtime_t latency) /* {{{ */
+static void change_bin_width (latency_counter_t *lc, cdtime_t latency) /* {{{ */
 {
   /* This function is called because the new value is above histogram's range.
    * First find the required bin width:
@@ -117,7 +117,7 @@ void change_bin_width (latency_counter_t *lc, cdtime_t latency) /* {{{ */
       CDTIME_T_TO_DOUBLE (new_bin_width));
 } /* }}} void change_bin_width */
 
-latency_counter_t *latency_counter_create () /* {{{ */
+latency_counter_t *latency_counter_create (void) /* {{{ */
 {
   latency_counter_t *lc;
 

diff --git a/src/utils_latency.h b/src/utils_latency.h
index 3787c77..e7c2fc3 100644 (file)
--- a/src/utils_latency.h
+++ b/src/utils_latency.h
@@ -30,7 +30,7 @@
 struct latency_counter_s;
 typedef struct latency_counter_s latency_counter_t;
 
-latency_counter_t *latency_counter_create ();
+latency_counter_t *latency_counter_create (void);
 void latency_counter_destroy (latency_counter_t *lc);
 
 void latency_counter_add (latency_counter_t *lc, cdtime_t latency);

diff --git a/src/utils_random.c b/src/utils_random.c
index b873845..548d1d8 100644 (file)
--- a/src/utils_random.c
+++ b/src/utils_random.c
@@ -24,10 +24,12 @@
  *   Florian Forster <octo at collectd.org>
  **/
 
+#include <pthread.h>
+
 #include "collectd.h"
 #include "utils_time.h"
+#include "utils_random.h"
 
-#include <pthread.h>
 
 static pthread_mutex_t lock = PTHREAD_MUTEX_INITIALIZER;
 static _Bool have_seed = 0;

diff --git a/src/utils_subst.c b/src/utils_subst.c
index a49f6db..ca1e933 100644 (file)
--- a/src/utils_subst.c
+++ b/src/utils_subst.c
@@ -25,6 +25,7 @@
 
 #include "collectd.h"
 #include "common.h"
+#include "utils_subst.h"
 
 char *subst (char *buf, size_t buflen, const char *string, int off1, int off2,
                const char *replacement)

diff --git a/src/xmms.c b/src/xmms.c
index 52beb65..51f80d9 100644 (file)
--- a/src/xmms.c
+++ b/src/xmms.c
@@ -43,7 +43,7 @@ static void cxmms_submit (const char *type, gauge_t value)
        plugin_dispatch_values (&vl);
 } /* void cxmms_submit */
 
-int cxmms_read (void)
+static int cxmms_read (void)
 {
   gint rate;
   gint freq;