Merge pull request #1289 from trenkel/master
authortrenkel <github@semidefinite.de>
Wed, 7 Oct 2015 14:51:29 +0000 (16:51 +0200)
committertrenkel <github@semidefinite.de>
Wed, 7 Oct 2015 14:51:29 +0000 (16:51 +0200)
python: Fix double-free bug.

src/python.c

index b7cc5b9..210d785 100644 (file)
@@ -302,7 +302,7 @@ void cpy_log_exception(const char *context) {
                Py_XDECREF(traceback);
                return;
        }
-       list = PyObject_CallFunction(cpy_format_exception, "NNN", type, value, traceback); /* New reference. */
+       list = PyObject_CallFunction(cpy_format_exception, "NNN", type, value, traceback); /* New reference. Steals references from "type", "value" and "traceback". */
        if (list)
                l = PyObject_Length(list);
        for (i = 0; i < l; ++i) {
@@ -322,9 +322,6 @@ void cpy_log_exception(const char *context) {
        }
        Py_XDECREF(list);
        PyErr_Clear();
-       Py_DECREF(type);
-       Py_XDECREF(value);
-       Py_XDECREF(traceback);
 }
 
 static int cpy_read_callback(user_data_t *data) {