X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=src%2Funixsock.c;h=6a8628a55eaf8fa3dbae2c152c1e1ac461053668;hb=a94f533;hp=d80091b1bd18bfffd290ae4c7a54b6086131605f;hpb=d767db104769bed7fefea61538bdacb364434e9a;p=collectd.git diff --git a/src/unixsock.c b/src/unixsock.c index d80091b1..6a8628a5 100644 --- a/src/unixsock.c +++ b/src/unixsock.c @@ -86,8 +86,8 @@ static int us_open_socket (void) memset (&sa, '\0', sizeof (sa)); sa.sun_family = AF_UNIX; - strncpy (sa.sun_path, (sock_file != NULL) ? sock_file : US_DEFAULT_PATH, - sizeof (sa.sun_path) - 1); + sstrncpy (sa.sun_path, (sock_file != NULL) ? sock_file : US_DEFAULT_PATH, + sizeof (sa.sun_path)); /* unlink (sa.sun_path); */ DEBUG ("unixsock plugin: socket path = %s", sa.sun_path); @@ -159,9 +159,6 @@ static void *us_handle_client (void *arg) { int fd; FILE *fhin, *fhout; - char buffer[1024]; - char *fields[128]; - int fields_num; fd = *((int *) arg); free (arg); @@ -202,7 +199,11 @@ static void *us_handle_client (void *arg) while (42) { - int len; + char buffer[1024]; + char buffer_copy[1024]; + char *fields[128]; + int fields_num; + int len; errno = 0; if (fgets (buffer, sizeof (buffer), fhin) == NULL) @@ -225,9 +226,9 @@ static void *us_handle_client (void *arg) if (len == 0) continue; - DEBUG ("fgets -> buffer = %s; len = %i;", buffer, len); + sstrncpy (buffer_copy, buffer, sizeof (buffer_copy)); - fields_num = strsplit (buffer, fields, + fields_num = strsplit (buffer_copy, fields, sizeof (fields) / sizeof (fields[0])); if (fields_num < 1) @@ -238,11 +239,11 @@ static void *us_handle_client (void *arg) if (strcasecmp (fields[0], "getval") == 0) { - handle_getval (fhout, fields, fields_num); + handle_getval (fhout, buffer); } else if (strcasecmp (fields[0], "putval") == 0) { - handle_putval (fhout, fields, fields_num); + handle_putval (fhout, buffer); } else if (strcasecmp (fields[0], "listval") == 0) { @@ -254,7 +255,7 @@ static void *us_handle_client (void *arg) } else if (strcasecmp (fields[0], "flush") == 0) { - handle_flush (fhout, fields, fields_num); + handle_flush (fhout, buffer); } else {