X-Git-Url: https://git.octo.it/?a=blobdiff_plain;f=bindings%2Fperl%2FCollectd%2FUnixsock.pm;h=c13622127cc431a64209df253bdd147769934b04;hb=a94f533;hp=cd910ed080e73d1779b2787f3d1230825c5b797c;hpb=b4d9bd23f3e04f9b42204d9954842524e2a7eb61;p=collectd.git

diff --git a/bindings/perl/Collectd/Unixsock.pm b/bindings/perl/Collectd/Unixsock.pm
index cd910ed0..c1362212 100644
--- a/bindings/perl/Collectd/Unixsock.pm
+++ b/bindings/perl/Collectd/Unixsock.pm
@@ -134,6 +134,22 @@ sub _parse_identifier
 	return ($ident);
 } # _parse_identifier
 
+sub _escape_argument
+{
+	my $string = shift;
+
+	if ($string =~ m/^\w+$/)
+	{
+		return ("$string");
+	}
+
+	$string =~ s#\\#\\\\#g;
+	$string =~ s#"#\\"#g;
+	$string = "\"$string\"";
+
+	return ($string);
+}
+
 =head1 PUBLIC METHODS
 
 =over 4
@@ -175,7 +191,7 @@ sub getval
 	my %args = @_;
 
 	my $status;
-	my $fh = $obj->{'sock'} or confess;
+	my $fh = $obj->{'sock'} or confess ('object has no filehandle');
 	my $msg;
 	my $identifier;
 
@@ -183,7 +199,7 @@ sub getval
 
 	$identifier = _create_identifier (\%args) or return;
 
-	$msg = "GETVAL $identifier\n";
+	$msg = 'GETVAL ' . _escape_argument ($identifier) . "\n";
 	#print "-> $msg";
 	send ($fh, $msg, 0) or confess ("send: $!");
 
@@ -240,7 +256,8 @@ sub putval
 
 	if (defined $args{'interval'})
 	{
-		$interval = ' interval=' . $args{'interval'};
+		$interval = ' interval='
+		. _escape_argument ($args{'interval'});
 	}
 
 	$identifier = _create_identifier (\%args) or return;
@@ -260,7 +277,10 @@ sub putval
 		$values = join (':', $time, map { defined ($_) ? $_ : 'U' } (@{$args{'values'}}));
 	}
 
-	$msg = "PUTVAL $identifier$interval $values\n";
+	$msg = 'PUTVAL '
+	. _escape_argument ($identifier)
+	. $interval
+	. ' ' . _escape_argument ($values) . "\n";
 	#print "-> $msg";
 	send ($fh, $msg, 0) or confess ("send: $!");
 	$msg = undef;
@@ -477,14 +497,8 @@ sub flush
 			{
 				return;
 			}
-			if ($ident_str =~ m/ /)
-			{
-				$ident_str =~ s#\\#\\\\#g;
-				$ident_str =~ s#"#\\"#g;
-				$ident_str = "\"$ident_str\"";
-			}
 
-			$msg .= " identifier=$ident_str";
+			$msg .= ' identifier=' . _escape_argument ($ident_str);
 		}
 	}