apache plugin: Fix a segmentation fault in the config handling of VerifyPeer / Verify...

[collectd.git] / src / apache.c

diff --git a/src/apache.c b/src/apache.c
index 59fb19b..d6712dc 100644 (file)
--- a/src/apache.c
+++ b/src/apache.c
@@ -134,15 +134,25 @@ static size_t apache_header_callback (void *buf, size_t size, size_t nmemb,
        }
 
        if (len <= 0)
-               return len;
+               return (len);
 
        /* look for the Server header */
-       if ((strstr(buf, "Server: ") != NULL) &&
-                       (strstr(buf, "lighttpd") != NULL)) {
+       if (strncasecmp (buf, "Server: ", strlen ("Server: ")) != 0)
+               return (len);
+
+       if (strstr (buf, "Apache") != NULL)
+               st->server_type = APACHE;
+       else if (strstr (buf, "lighttpd") != NULL)
                st->server_type = LIGHTTPD;
+       else
+       {
+               const char *hdr = buf;
+
+               hdr += strlen ("Server: ");
+               NOTICE ("apache plugin: Unknown server software: %s", hdr);
        }
 
-       return len;
+       return (len);
 } /* apache_header_callback */
 
 /* Configuration handling functiions
@@ -192,7 +202,7 @@ static int config_set_boolean (int *ret_boolean, /* {{{ */
                return (-1);
        }
 
-       if (ci->values[0].type != OCONFIG_TYPE_BOOLEAN)
+       if (ci->values[0].type == OCONFIG_TYPE_BOOLEAN)
        {
                if (ci->values[0].value.boolean)
                        *ret_boolean = 1;
@@ -202,13 +212,9 @@ static int config_set_boolean (int *ret_boolean, /* {{{ */
        else /* if (ci->values[0].type != OCONFIG_TYPE_STRING) */
        {
                char *string = ci->values[0].value.string;
-               if ((strcasecmp ("true", string) == 0)
-                               || (strcasecmp ("yes", string) == 0)
-                               || (strcasecmp ("on", string) == 0))
+               if (IS_TRUE (string))
                        *ret_boolean = 1;
-               else if ((strcasecmp ("false", string) == 0)
-                               || (strcasecmp ("no", string) == 0)
-                               || (strcasecmp ("off", string) == 0))
+               else if (IS_FALSE (string))
                        *ret_boolean = 0;
                else
                {
@@ -413,6 +419,9 @@ static int init_host (apache_t *st) /* {{{ */
                        st->server_type = APACHE;
                else if (strcasecmp(st->server, "lighttpd") == 0)
                        st->server_type = LIGHTTPD;
+               else
+                       WARNING ("apache plugin: Unknown `Server' setting: %s",
+                                       st->server);
        }
 
        /* if not found register a header callback to determine the server_type */
@@ -445,6 +454,7 @@ static int init_host (apache_t *st) /* {{{ */
        }
 
        curl_easy_setopt (st->curl, CURLOPT_URL, st->url);
+       curl_easy_setopt (st->curl, CURLOPT_FOLLOWLOCATION, 1);
 
        if (st->verify_peer != 0)
        {
@@ -583,7 +593,8 @@ static void submit_scoreboard (char *buf, apache_t *st)
                submit_gauge ("apache_scoreboard", "logging"  , logging, st);
                submit_gauge ("apache_scoreboard", "finishing", finishing, st);
                submit_gauge ("apache_scoreboard", "idle_cleanup", idle_cleanup, st);
-       } else
+       }
+       else
        {
                submit_gauge ("apache_scoreboard", "connect"       , open, st);
                submit_gauge ("apache_scoreboard", "close"         , closing, st);
@@ -638,7 +649,11 @@ static int apache_read_host (user_data_t *user_data) /* {{{ */
 
        /* fallback - server_type to apache if not set at this time */
        if (st->server_type == -1)
+       {
+               WARNING ("apache plugin: Unable to determine server software "
+                               "automatically. Will assume Apache.");
                st->server_type = APACHE;
+       }
 
        ptr = st->apache_buffer;
        saveptr = NULL;