projects
/
supertux.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
Remove bogus asserts, fixes Coverity #29378 and #29408
[supertux.git]
/
src
/
math
/
random_generator.cpp
diff --git
a/src/math/random_generator.cpp
b/src/math/random_generator.cpp
index
fe4086b
..
6429c53
100644
(file)
--- a/
src/math/random_generator.cpp
+++ b/
src/math/random_generator.cpp
@@
-87,11
+87,10
@@
int RandomGenerator::rand() {
}
int RandomGenerator::rand(int v) {
}
int RandomGenerator::rand(int v) {
- assert(v >= 0
&& v <= RandomGenerator::rand_max
); // illegal arg
+ assert(v >= 0); // illegal arg
// remove biases, esp. when v is large (e.g. v == (rand_max/4)*3;)
int rv, maxV =(RandomGenerator::rand_max / v) * v;
// remove biases, esp. when v is large (e.g. v == (rand_max/4)*3;)
int rv, maxV =(RandomGenerator::rand_max / v) * v;
- assert(maxV <= RandomGenerator::rand_max);
while ((rv = RandomGenerator::random()) >= maxV)
;
return rv % v; // mod it down to 0..(maxV-1)
while ((rv = RandomGenerator::random()) >= maxV)
;
return rv % v; // mod it down to 0..(maxV-1)